third_party/WebKit/Source/wtf/TypeTraits.h - Issue 2110183005: WTF::Vector: Fix primitive types identified as not safe to memcpy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/TypeTraits.h

Issue 2110183005: WTF::Vector: Fix primitive types identified as not safe to memcpy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded garbage; add a test for pointers. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/wtf/TypeTraits.h

diff --git a/third_party/WebKit/Source/wtf/TypeTraits.h b/third_party/WebKit/Source/wtf/TypeTraits.h

index 35960152fa572b13367dabc8dfa94524373f3968..c5199c173c2c4d6b9286d2ee525480ff9e326986 100644

--- a/third_party/WebKit/Source/wtf/TypeTraits.h

+++ b/third_party/WebKit/Source/wtf/TypeTraits.h

@@ -63,7 +63,7 @@ class IsAssignable {

char padding[8];

};

- template <typename T2, typename From2, typename = decltype(std::declval<T2>() = std::declval<From2>())>

+ template <typename T2, typename From2, typename = decltype(std::declval<T2&>() = std::declval<From2>())>

static YesType checkAssignability(int);

template <typename T2, typename From2>

static NoType checkAssignability(...);

« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/VectorTest.cpp » ('j') | no next file with comments »