content/renderer/service_worker/service_worker_context_client.cc - Issue 2110163002: Correctly set initiated_in_secure_context on requests from shared/service workers,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2110163002: Correctly set initiated_in_secure_context on requests from shared/service workers, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@skip-service-worker-foreign-fetch

Patch Set: wrap layout test at 80 columns Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/foreign_fetch_request_handler.cc ('k') | content/renderer/shared_worker/embedded_shared_worker_stub.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_context_client.cc

diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc

index eee91269a9043fcecba441f8b0c58017ece0f4b0..7988b852c2a3d8f5e4de5aece47368b3a2e36dcd 100644

--- a/content/renderer/service_worker/service_worker_context_client.cc

+++ b/content/renderer/service_worker/service_worker_context_client.cc

@@ -99,6 +99,9 @@ class WebServiceWorkerNetworkProviderImpl

std::unique_ptr<RequestExtraData> extra_data(new RequestExtraData);

extra_data->set_service_worker_provider_id(provider->provider_id());

extra_data->set_originated_from_service_worker(true);

+ // Service workers are only available in secure contexts, so all requests

+ // are initiated in a secure context.

+ extra_data->set_initiated_in_secure_context(true);

request.setExtraData(extra_data.release());

}

};