Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2110123003: Move dump of batches to be after the forwardCombine call in prepareBatches (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move dump of batches to be after the forwardCombine call in prepareBatches This eliminates an unfortunate red herring. Text batching isn't actually as bad as I had feared. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110123003 Committed: https://skia.googlesource.com/skia/+/27fe1f849d2b6f96b49cc919df7d5f6d74598aa1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/gpu/GrDrawingManager.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
robertphillips
4 years, 5 months ago (2016-06-29 18:32:25 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110123003/1
4 years, 5 months ago (2016-06-29 18:32:52 UTC) #6
bsalomon
lgtm
4 years, 5 months ago (2016-06-29 18:45:12 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 18:51:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110123003/1
4 years, 5 months ago (2016-06-29 20:42:24 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 20:43:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/27fe1f849d2b6f96b49cc919df7d5f6d74598aa1

Powered by Google App Engine
This is Rietveld 408576698