Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2110053002: [wasm] Cleanup AST decoder. Remove Tree and TreeResult. (Closed)

Created:
4 years, 5 months ago by titzer
Modified:
4 years, 5 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Cleanup AST decoder. Remove Tree and TreeResult. R=ahaas@chromium.org BUG= Committed: https://crrev.com/c4588df160c2ce295398a2cfc32026f996930a18 Cr-Commit-Position: refs/heads/master@{#37387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -61 lines) Patch
M src/compiler/wasm-compiler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wasm/ast-decoder.h View 2 chunks +18 lines, -15 lines 0 comments Download
M src/wasm/ast-decoder.cc View 5 chunks +15 lines, -41 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 5 months ago (2016-06-29 11:13:01 UTC) #1
ahaas
lgtm
4 years, 5 months ago (2016-06-29 11:19:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110053002/1
4 years, 5 months ago (2016-06-29 11:20:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 11:39:52 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 11:40:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4588df160c2ce295398a2cfc32026f996930a18
Cr-Commit-Position: refs/heads/master@{#37387}

Powered by Google App Engine
This is Rietveld 408576698