Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 211005: Fix a bug where the autocomplete popup does not hide after selection (Closed)

Created:
11 years, 3 months ago by Paul Godavari
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Fix a bug introduced by a WebKit merge where we did not tell our autocomplete popup to hide when it was closed. BUG=22032 TEST=Navigate to a page with an autocompletable input box (e.g. google.com login page) and notice that the autocomplete box hides when you select an item from it and hit enter. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26503

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webkit/glue/webview_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Godavari
11 years, 3 months ago (2009-09-17 02:19:40 UTC) #1
dglazkov
LGTM.
11 years, 3 months ago (2009-09-17 02:54:06 UTC) #2
darin (slow to review)
11 years, 3 months ago (2009-09-17 15:52:52 UTC) #3
Thanks for fixing this!  This was fallout from my merge.  I should have
realized that this was more than just an extra notification :-/-Darin

On Wed, Sep 16, 2009 at 7:19 PM, <paul@chromium.org> wrote:

> Reviewers: Dimitri Glazkov,
>
> Description:
> Fix a bug introduced by a WebKit merge where we did not
> tell our autocomplete popup to hide when it was closed.
>
> BUG=22032
> TEST=Navigate to a page with an autocompletable input box
>     (e.g. google.com login page) and notice that the
>     autocomplete box hides when you select an item from it
>     and hit enter.
>
> Please review this at http://codereview.chromium.org/211005
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/glue/webview_impl.cc
>
>
> Index: webkit/glue/webview_impl.cc
> ===================================================================
> --- webkit/glue/webview_impl.cc (revision 26304)
> +++ webkit/glue/webview_impl.cc (working copy)
> @@ -234,6 +234,7 @@
>     return selected_index_;
>   }
>   virtual void popupDidHide() {
> +    hidePopup();
>   }
>   virtual void hidePopup() {
>     webview_->HideAutoCompletePopup();
>
>
>

Powered by Google App Engine
This is Rietveld 408576698