Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2110033002: Remove unnecessary includes in src/pdf/ (Closed)

Created:
4 years, 5 months ago by mkollaro
Modified:
4 years, 5 months ago
Reviewers:
hal.canary, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unnecessary includes in src/pdf/ Use forward declaration more. BUG=None GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110033002 Committed: https://skia.googlesource.com/skia/+/b8d6af169bf631dcb68ba5a796436434ff78be65

Patch Set 1 #

Patch Set 2 : fix order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -43 lines) Patch
M src/pdf/SkDeflate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/pdf/SkDeflate.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFBitmap.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/pdf/SkPDFBitmap.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFCanon.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/pdf/SkPDFCanon.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFDevice.h View 1 2 chunks +2 lines, -7 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/pdf/SkPDFDocument.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/pdf/SkPDFFont.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFFormXObject.h View 1 1 chunk +3 lines, -6 lines 0 comments Download
M src/pdf/SkPDFGraphicState.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFMetadata.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFResourceDict.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/pdf/SkPDFResourceDict.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFStream.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/pdf/SkPDFStream.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFTypes.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFUtils.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFUtils.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
mkollaro
4 years, 5 months ago (2016-06-29 08:28:27 UTC) #4
reed1
4 years, 5 months ago (2016-06-29 10:23:59 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110033002/20001
4 years, 5 months ago (2016-06-29 10:46:59 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 11:03:11 UTC) #10
hal.canary
On 2016/06/29 11:03:11, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 5 months ago (2016-06-29 12:11:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110033002/20001
4 years, 5 months ago (2016-06-29 12:11:32 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 12:12:36 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b8d6af169bf631dcb68ba5a796436434ff78be65

Powered by Google App Engine
This is Rietveld 408576698