DevTools: rename SourceEditor to SourceView, make entire SourcesPanel a drop target.

Source/devtools/front_end/SourcesEditor.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @implements {WebInspector.TabbedEditorContainerDelegate}
  * @implements {WebInspector.Searchable}
  * @implements {WebInspector.Replaceable}
- * @extends {WebInspector.Object}
+ * @extends {WebInspector.VBox}
  * @param {!WebInspector.Workspace} workspace
  * @param {!WebInspector.SourcesPanel} sourcesPanel
  */
-WebInspector.SourcesEditor = function(workspace, sourcesPanel)
+WebInspector.SourcesView = function(workspace, sourcesPanel)
 {
+    WebInspector.VBox.call(this);
+    this.registerRequiredCSS("sourcesView.css");
+    this.element.id = "sources-panel-sources-view";
+
     this._workspace = workspace;
     this._sourcesPanel = sourcesPanel;
 
-    this._sourcesView = new WebInspector.SourcesView();
-
     this._searchableView = new WebInspector.SearchableView(this);
     this._searchableView.setMinimalSearchQuerySize(0);
-    this._searchableView.show(this._sourcesView.element);
+    this._searchableView.show(this.element);
 
     /** @type {!Map.<!WebInspector.UISourceCode, !WebInspector.SourceFrame>} */
     this._sourceFramesByUISourceCode = new Map();
 
     var tabbedEditorPlaceholderText = WebInspector.isMac() ? WebInspector.UIString("Hit Cmd+O to open a file") : WebInspector.UIString("Hit Ctrl+O to open a file");
     this._editorContainer = new WebInspector.TabbedEditorContainer(this, "previouslyViewedFiles", tabbedEditorPlaceholderText);
     this._editorContainer.show(this._searchableView.element);
     this._editorContainer.addEventListener(WebInspector.TabbedEditorContainer.Events.EditorSelected, this._editorSelected, this);
     this._editorContainer.addEventListener(WebInspector.TabbedEditorContainer.Events.EditorClosed, this._editorClosed, this);
 
     this._historyManager = new WebInspector.EditingLocationHistoryManager(this, this.currentSourceFrame.bind(this));
 
     this._scriptViewStatusBarItemsContainer = document.createElement("div");
     this._scriptViewStatusBarItemsContainer.className = "inline-block";
 
     this._scriptViewStatusBarTextContainer = document.createElement("div");
     this._scriptViewStatusBarTextContainer.className = "hbox";
 
-    this._statusBarContainerElement = this._sourcesView.element.createChild("div", "sources-status-bar");
+    this._statusBarContainerElement = this.element.createChild("div", "sources-status-bar");
 
     /**
-     * @this {WebInspector.SourcesEditor}
-     * @param {!WebInspector.SourcesEditor.EditorAction} EditorAction
+     * @this {WebInspector.SourcesView}
+     * @param {!WebInspector.SourcesView.EditorAction} EditorAction
      */
     function appendButtonForExtension(EditorAction)
     {
         this._statusBarContainerElement.appendChild(EditorAction.button(this));
     }
-    var editorActions = /** @type {!Array.<!WebInspector.SourcesEditor.EditorAction>} */ (WebInspector.moduleManager.instances(WebInspector.SourcesEditor.EditorAction));
+    var editorActions = /** @type {!Array.<!WebInspector.SourcesView.EditorAction>} */ (WebInspector.moduleManager.instances(WebInspector.SourcesView.EditorAction));
     editorActions.forEach(appendButtonForExtension.bind(this));
 
     this._statusBarContainerElement.appendChild(this._scriptViewStatusBarItemsContainer);
     this._statusBarContainerElement.appendChild(this._scriptViewStatusBarTextContainer);
 
     WebInspector.startBatchUpdate();
     this._workspace.uiSourceCodes().forEach(this._addUISourceCode.bind(this));
     WebInspector.endBatchUpdate();
 
     this._workspace.addEventListener(WebInspector.Workspace.Events.UISourceCodeAdded, this._uiSourceCodeAdded, this);
     this._workspace.addEventListener(WebInspector.Workspace.Events.UISourceCodeRemoved, this._uiSourceCodeRemoved, this);
     this._workspace.addEventListener(WebInspector.Workspace.Events.ProjectWillReset, this._projectWillReset.bind(this), this);
 
     function handleBeforeUnload(event)
     {
         if (event.returnValue)
             return;
         var unsavedSourceCodes = WebInspector.workspace.unsavedSourceCodes();
         if (!unsavedSourceCodes.length)
             return;
 
         event.returnValue = WebInspector.UIString("DevTools have unsaved changes that will be permanently lost.");
         WebInspector.inspectorView.showPanel("sources");
         for (var i = 0; i < unsavedSourceCodes.length; ++i)
             WebInspector.panels.sources.showUISourceCode(unsavedSourceCodes[i]);
     }
     window.addEventListener("beforeunload", handleBeforeUnload, true);
 }
 
-WebInspector.SourcesEditor.Events = {
+WebInspector.SourcesView.Events = {
     EditorClosed: "EditorClosed",
     EditorSelected: "EditorSelected",
 }
 
-WebInspector.SourcesEditor.prototype = {
+WebInspector.SourcesView.prototype = {
     /**
      * @param {function(!Array.<!WebInspector.KeyboardShortcut.Descriptor>, function(?Event=):boolean)} registerShortcutDelegate
      */
     registerShortcuts: function(registerShortcutDelegate)
     {
         registerShortcutDelegate(WebInspector.ShortcutsScreen.SourcesPanelShortcuts.JumpToPreviousLocation, this._onJumpToPreviousLocation.bind(this));
         registerShortcutDelegate(WebInspector.ShortcutsScreen.SourcesPanelShortcuts.JumpToNextLocation, this._onJumpToNextLocation.bind(this));
         registerShortcutDelegate(WebInspector.ShortcutsScreen.SourcesPanelShortcuts.CloseEditorTab, this._onCloseEditorTab.bind(this));
         registerShortcutDelegate(WebInspector.ShortcutsScreen.SourcesPanelShortcuts.GoToLine, this._showGoToLineDialog.bind(this));
         registerShortcutDelegate(WebInspector.ShortcutsScreen.SourcesPanelShortcuts.GoToMember, this._showOutlineDialog.bind(this));
@@ skipping 18 matching lines @@
 
     /**
      * @return {!WebInspector.SearchableView}
      */
     searchableView: function()
     {
         return this._searchableView;
     },
 
     /**
-     * @return {!WebInspector.SourcesView}
-     */
-    sourcesView: function()
-    {
-        return this._sourcesView;
-    },
-
-    /**
      * @return {!WebInspector.View}
      */
     visibleView: function()
     {
         return this._editorContainer.visibleView;
     },
 
     /**
      * @return {?WebInspector.SourceFrame}
      */
@@ skipping 266 matching lines @@
             wasSelected = true;
         }
 
         // SourcesNavigator does not need to update on EditorClosed.
         this._updateScriptViewStatusBarItems();
         this._searchableView.resetSearch();
 
         var data = {};
         data.uiSourceCode = uiSourceCode;
         data.wasSelected = wasSelected;
-        this.dispatchEventToListeners(WebInspector.SourcesEditor.Events.EditorClosed, data);
+        this.dispatchEventToListeners(WebInspector.SourcesView.Events.EditorClosed, data);
     },
 
     _editorSelected: function(event)
     {
         var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (event.data.currentFile);
         var shouldUseHistoryManager = uiSourceCode !== this._currentUISourceCode && event.data.userGesture;
         if (shouldUseHistoryManager)
             this._historyManager.updateCurrentState();
         var sourceFrame = this._showFile(uiSourceCode);
         if (shouldUseHistoryManager)
             this._historyManager.pushNewState();
 
         this._searchableView.setReplaceable(!!sourceFrame && sourceFrame.canEditSource());
         this._searchableView.resetSearch();
 
-        this.dispatchEventToListeners(WebInspector.SourcesEditor.Events.EditorSelected, uiSourceCode);
+        this.dispatchEventToListeners(WebInspector.SourcesView.Events.EditorSelected, uiSourceCode);
     },
 
     /**
      * @param {!WebInspector.UISourceCode} uiSourceCode
      */
     sourceRenamed: function(uiSourceCode)
     {
         this._recreateSourceFrameIfNeeded(uiSourceCode);
     },
 
@@ skipping 17 matching lines @@
         var sourceFrame = this.currentSourceFrame();
         if (!sourceFrame)
             return;
 
         this._searchView = sourceFrame;
         this._searchQuery = query;
 
         /**
          * @param {!WebInspector.View} view
          * @param {number} searchMatches
-         * @this {WebInspector.SourcesEditor}
+         * @this {WebInspector.SourcesView}
          */
         function finishedCallback(view, searchMatches)
         {
             if (!searchMatches)
                 return;
 
             this._searchableView.updateSearchMatchesCount(searchMatches);
         }
 
         /**
          * @param {number} currentMatchIndex
-         * @this {WebInspector.SourcesEditor}
+         * @this {WebInspector.SourcesView}
          */
         function currentMatchChanged(currentMatchIndex)
         {
             this._searchableView.updateCurrentMatchIndex(currentMatchIndex);
         }
 
         /**
-         * @this {WebInspector.SourcesEditor}
+         * @this {WebInspector.SourcesView}
          */
         function searchResultsChanged()
         {
             this._searchableView.cancelSearch();
         }
 
         this._searchView.performSearch(query, shouldJump, finishedCallback.bind(this), currentMatchChanged.bind(this), searchResultsChanged.bind(this));
     },
 
     jumpToNextSearchResult: function()
@@ skipping 57 matching lines @@
      */
     _showOutlineDialog: function(event)
     {
         var uiSourceCode = this._editorContainer.currentFile();
         if (!uiSourceCode)
             return false;
 
         switch (uiSourceCode.contentType()) {
         case WebInspector.resourceTypes.Document:
         case WebInspector.resourceTypes.Script:
-            WebInspector.JavaScriptOutlineDialog.show(this._sourcesView, uiSourceCode, this.showSourceLocation.bind(this, uiSourceCode));
+            WebInspector.JavaScriptOutlineDialog.show(this, uiSourceCode, this.showSourceLocation.bind(this, uiSourceCode));
             return true;
         case WebInspector.resourceTypes.Stylesheet:
-            WebInspector.StyleSheetOutlineDialog.show(this._sourcesView, uiSourceCode, this.showSourceLocation.bind(this, uiSourceCode));
+            WebInspector.StyleSheetOutlineDialog.show(this, uiSourceCode, this.showSourceLocation.bind(this, uiSourceCode));
             return true;
         }
         return false;
     },
 
     /**
      * @param {string=} query
      */
     showOpenResourceDialog: function(query)
     {
         var uiSourceCodes = this._editorContainer.historyUISourceCodes();
         /** @type {!Map.<!WebInspector.UISourceCode, number>} */
         var defaultScores = new Map();
         for (var i = 1; i < uiSourceCodes.length; ++i) // Skip current element
             defaultScores.put(uiSourceCodes[i], uiSourceCodes.length - i);
-        WebInspector.OpenResourceDialog.show(this, this._sourcesView.element, query, defaultScores);
+        WebInspector.OpenResourceDialog.show(this, this.element, query, defaultScores);
     },
 
     /**
      * @param {?Event=} event
      * @return {boolean}
      */
     _showGoToLineDialog: function(event)
     {
         this.showOpenResourceDialog(":");
         return true;
@@ skipping 17 matching lines @@
     },
 
     /**
      * @param {boolean} active
      */
     toggleBreakpointsActiveState: function(active)
     {
         this._editorContainer.view.element.classList.toggle("breakpoints-deactivated", !active);
     },
 
-    __proto__: WebInspector.Object.prototype
-}
-
-/**
- * @constructor
- * @extends {WebInspector.VBox}
- */
-WebInspector.SourcesView = function()
-{
-    WebInspector.VBox.call(this);
-    this.registerRequiredCSS("sourcesView.css");
-    this.element.id = "sources-panel-sources-view";
-    this.element.addEventListener("dragenter", this._onDragEnter.bind(this), true);
-    this.element.addEventListener("dragover", this._onDragOver.bind(this), true);
-}
-
-WebInspector.SourcesView.dragAndDropFilesType = "Files";
-
-WebInspector.SourcesView.prototype = {
-    _onDragEnter: function (event)
-    {
-        if (event.dataTransfer.types.indexOf(WebInspector.SourcesView.dragAndDropFilesType) === -1)
-            return;
-        event.consume(true);
-    },
-
-    _onDragOver: function (event)
-    {
-        if (event.dataTransfer.types.indexOf(WebInspector.SourcesView.dragAndDropFilesType) === -1)
-            return;
-        event.consume(true);
-        if (this._dragMaskElement)
-            return;
-        this._dragMaskElement = this.element.createChild("div", "fill drag-mask");
-        this._dragMaskElement.addEventListener("drop", this._onDrop.bind(this), true);
-        this._dragMaskElement.addEventListener("dragleave", this._onDragLeave.bind(this), true);
-    },
-
-    _onDrop: function (event)
-    {
-        event.consume(true);
-        this._removeMask();
-        var items = /** @type {!Array.<!DataTransferItem>} */ (event.dataTransfer.items);
-        if (!items.length)
-            return;
-        var entry = items[0].webkitGetAsEntry();
-        if (!entry.isDirectory)
-            return;
-        InspectorFrontendHost.upgradeDraggedFileSystemPermissions(entry.filesystem);
-    },
-
-    _onDragLeave: function (event)
-    {
-        event.consume(true);
-        this._removeMask();
-    },
-
-    _removeMask: function ()
-    {
-        this._dragMaskElement.remove();
-        delete this._dragMaskElement;
-    },
-
     __proto__: WebInspector.VBox.prototype
 }
 
 /**
  * @interface
  */
-WebInspector.SourcesEditor.EditorAction = function()
+WebInspector.SourcesView.EditorAction = function()
 {
 }
 
-WebInspector.SourcesEditor.EditorAction.prototype = {
+WebInspector.SourcesView.EditorAction.prototype = {
     /**
-     * @param {!WebInspector.SourcesEditor} sourcesEditor
+     * @param {!WebInspector.SourcesView} sourcesView
      * @return {!Element}
      */
-    button: function(sourcesEditor) { }
+    button: function(sourcesView) { }
 }