Chromium Code Reviews
DescriptionRemove incorrect assert in PaymentRequest address editor UI.
The address editor in PaymentRequest UI needs to set the value of the
country dropdown when editing or create a new shipping address. This
change to the dropdown should not fire a callback that re-arranges the
address input fields. This is accomplished via the
EditorFieldModel.setValue() call. Therefore, asserting that setValue()
is not used for dropdowns is incorrect.
The mCountryField.setValue() call has been moved below the
mCountryField.setDropdownCallback() to make it clear to the reader that
the callback is not fired intentionally, instead of accidentally.
BUG=624653
TBR=dfalcantara
Committed: https://crrev.com/e5478255cd31bffa2867db84946f9512cba5a3fd
Cr-Commit-Position: refs/heads/master@{#403085}
Patch Set 1 #
Messages
Total messages: 11 (5 generated)
|
||||||||||||||||||||||||||||