Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2110013003: Remove incorrect assert in PaymentRequest address editor UI. (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews, horo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove incorrect assert in PaymentRequest address editor UI. The address editor in PaymentRequest UI needs to set the value of the country dropdown when editing or create a new shipping address. This change to the dropdown should not fire a callback that re-arranges the address input fields. This is accomplished via the EditorFieldModel.setValue() call. Therefore, asserting that setValue() is not used for dropdowns is incorrect. The mCountryField.setValue() call has been moved below the mCountryField.setDropdownCallback() to make it clear to the reader that the callback is not fired intentionally, instead of accidentally. BUG=624653 TBR=dfalcantara Committed: https://crrev.com/e5478255cd31bffa2867db84946f9512cba5a3fd Cr-Commit-Position: refs/heads/master@{#403085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
please use gerrit instead
dfalcantara@, ptal. horo@, fyi.
4 years, 5 months ago (2016-06-30 03:01:01 UTC) #2
please use gerrit instead
Since this change is trivial and fixes android bots, I'm going to TBR it.
4 years, 5 months ago (2016-06-30 03:53:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110013003/1
4 years, 5 months ago (2016-06-30 03:54:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 03:58:40 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 03:58:45 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 04:00:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5478255cd31bffa2867db84946f9512cba5a3fd
Cr-Commit-Position: refs/heads/master@{#403085}

Powered by Google App Engine
This is Rietveld 408576698