Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2109943003: [heap] Reland uncommit unused large object page memory. (Closed)

Created:
4 years, 5 months ago by Hannes Payer (out of office)
Modified:
4 years, 5 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland uncommit unused large object page memory. BUG= Committed: https://crrev.com/46a365faae01636c48412662a1befe551a71be6e Cr-Commit-Position: refs/heads/master@{#37376}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : brakets #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -22 lines) Patch
M src/base/hashmap.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/base/platform/platform.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/base/platform/platform-linux.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/base/platform/platform-macos.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/base/platform/platform-win32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +13 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 1 2 3 7 chunks +89 lines, -21 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +23 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-617882.js View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
lgtm
4 years, 5 months ago (2016-06-29 09:00:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109943003/60001
4 years, 5 months ago (2016-06-29 09:01:08 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-29 09:37:04 UTC) #5
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/46a365faae01636c48412662a1befe551a71be6e Cr-Commit-Position: refs/heads/master@{#37376}
4 years, 5 months ago (2016-06-29 09:38:59 UTC) #7
adamk
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2117853003/ by adamk@chromium.org. ...
4 years, 5 months ago (2016-07-01 18:17:53 UTC) #8
adamk
4 years, 5 months ago (2016-07-01 18:43:48 UTC) #9
Message was sent while issue was closed.
On 2016/07/01 18:17:53, adamk wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2117853003/ by mailto:adamk@chromium.org.
> 
> The reason for reverting is: Caused crashes on Canary.

Not reverting, has already been fixed.

Powered by Google App Engine
This is Rietveld 408576698