Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2109913005: Revert of Better encapsulate oval/rrect batchs. (Closed)

Created:
4 years, 5 months ago by dogben
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Better encapsulate oval/rrect batchs. (patchset #3 id:40001 of https://codereview.chromium.org/2104423003/ ) Reason for revert: Causing assertion error on Test-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug (https://chromium-swarm.appspot.com/user/task/2fb6ee239783b910) and Test-Win8-MSVC-ShuttleA-GPU-GTX960-x86_64-Debug (https://chromium-swarm.appspot.com/user/task/2fb6ebcc157fed10). Original issue's description: > Better encapsulate oval/rrect batchs. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104423003 > > Committed: https://skia.googlesource.com/skia/+/5fd209e8ee477c703bc5c11b008f247d515fc0fc TBR=robertphillips@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/fc5b70a8e427ee115868786fa361c2c813ab566b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -393 lines) Patch
M src/gpu/GrOvalRenderer.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 17 chunks +425 lines, -393 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dogben
Created Revert of Better encapsulate oval/rrect batchs.
4 years, 5 months ago (2016-06-29 22:24:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109913005/1
4 years, 5 months ago (2016-06-29 22:24:54 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:25:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fc5b70a8e427ee115868786fa361c2c813ab566b

Powered by Google App Engine
This is Rietveld 408576698