Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2109913003: Reland "[heap] Optimize ArrayBuffer tracking" (Closed)

Created:
4 years, 5 months ago by Michael Lippautz
Modified:
4 years, 5 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Optimize ArrayBuffer tracking" With the current approach we only need to track using an unordered set as we can still access the backing store pointer and length by the time we free the backing store. Reland: The issue was fixed in 67b5a501db179412479e827e51c43515e4196b27. BUG=chromium:619491, chromium:611688 LOG=N R=ulan@chromium.org This reverts commit 0e1eaec71d5c6d05169308a71eaa51571e7c4f70. Committed: https://crrev.com/f58dd088f0886f838f35a38613cd7b1a66f0cd63 Cr-Commit-Position: refs/heads/master@{#37399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -29 lines) Patch
M src/heap/array-buffer-tracker.h View 5 chunks +6 lines, -7 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 3 chunks +16 lines, -13 lines 0 comments Download
M src/heap/array-buffer-tracker-inl.h View 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Michael Lippautz
4 years, 5 months ago (2016-06-29 13:38:05 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109913003/1
4 years, 5 months ago (2016-06-29 13:38:57 UTC) #7
ulan
lgtm
4 years, 5 months ago (2016-06-29 13:46:29 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 14:04:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109913003/1
4 years, 5 months ago (2016-06-29 14:51:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 14:53:48 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 14:54:40 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f58dd088f0886f838f35a38613cd7b1a66f0cd63
Cr-Commit-Position: refs/heads/master@{#37399}

Powered by Google App Engine
This is Rietveld 408576698