Fix assert in Flash component install.

Fix assert in Flash component install.

BUG=

Committed: https://crrev.com/df973871410891db6f94d224327d8c7cb4b8ae1e
Cr-Commit-Position: refs/heads/master@{#403218}

[waffles, 2016-06-28 22:11:14]

waffles@chromium.org changed reviewers:
+ sorin@chromium.org

[waffles, 2016-06-28 22:11:15]

PTAL.

[Sorin Jianu, 2016-06-28 23:21:33]

lgtm

[waffles, 2016-06-30 16:18:20]

The CQ bit was checked by waffles@chromium.org

[commit-bot: I haz the power, 2016-06-30 16:18:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[waffles, 2016-06-30 16:38:01]

The CQ bit was unchecked by waffles@chromium.org

[waffles, 2016-06-30 16:48:26]

The CQ bit was checked by waffles@chromium.org

[commit-bot: I haz the power, 2016-06-30 16:48:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 17:55:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-30 17:56:00]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 17:57:46]

Description was changed from

==========
Fix assert in Flash component install.

BUG=
==========

to

==========
Fix assert in Flash component install.

BUG=

Committed: https://crrev.com/df973871410891db6f94d224327d8c7cb4b8ae1e
Cr-Commit-Position: refs/heads/master@{#403218}
==========

[commit-bot: I haz the power, 2016-06-30 17:57:47]

Patchset 1 (id:??) landed as
https://crrev.com/df973871410891db6f94d224327d8c7cb4b8ae1e
Cr-Commit-Position: refs/heads/master@{#403218}

[kelvinp, 2016-06-30 18:42:57]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2114753002/ by kelvinp@chromium.org.

The reason for reverting is: Compilation failure in Google Chrome Mac

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/b...


Detailed message:

In file included from ../../base/bind_internal.h:13:
../../base/bind_helpers.h:412:7: error: implicit instantiation of undefined
template 'base::internal::DropTypeListItemImpl<1, base::internal::TypeList<> >'
    : DropTypeListItemImpl<n - 1, TypeList<List...>> {};
      ^
../../base/bind_helpers.h:426:1: note: in instantiation of template class
'base::internal::DropTypeListItemImpl<2,
base::internal::TypeList<component_updater::ComponentUpdateService *> >'
requested here
using DropTypeListItem = typename DropTypeListItemImpl<n, List>::Type;
^
../../base/bind_internal.h:395:23: note: in instantiation of template type alias
'DropTypeListItem' requested here
  using UnboundArgs = DropTypeListItem<sizeof...(BoundArgs), Args>;
                      ^
../../base/bind_internal.h:437:1: note: in instantiation of template class
'base::internal::MakeUnboundRunTypeImpl<void
(*)(component_updater::ComponentUpdateService *), const base::FilePath &, const
base::Version &>' requested here
using MakeUnboundRunType =
^
../../base/bind.h:50:23: note: in instantiation of template type alias
'MakeUnboundRunType' requested here
inline base::Callback<MakeUnboundRunType<Functor, Args...>>
                      ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:113:7:
note: while substituting deduced template arguments into function template
'Bind' [with Functor = void (*)(component_updater::ComponentUpdateService *),
Args = <const base::FilePath &, const base::Version &>]
      base::Bind(&RegisterPepperFlashWithChrome, path, version));
      ^
../../base/bind_helpers.h:407:8: note: template is declared here
struct DropTypeListItemImpl;
       ^
../../base/bind_helpers.h:480:1: error: implicit instantiation of undefined
template 'base::internal::MakeFunctionTypeImpl<void, int>'
using MakeFunctionType = typename MakeFunctionTypeImpl<R, ArgList>::Type;
^
../../base/bind_internal.h:396:16: note: in instantiation of template type alias
'MakeFunctionType' requested here
  using Type = MakeFunctionType<ReturnType, UnboundArgs>;
               ^
../../base/bind_internal.h:437:1: note: in instantiation of template class
'base::internal::MakeUnboundRunTypeImpl<void
(*)(component_updater::ComponentUpdateService *), const base::FilePath &, const
base::Version &>' requested here
using MakeUnboundRunType =
^
../../base/bind.h:50:23: note: in instantiation of template type alias
'MakeUnboundRunType' requested here
inline base::Callback<MakeUnboundRunType<Functor, Args...>>
                      ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:113:7:
note: while substituting deduced template arguments into function template
'Bind' [with Functor = void (*)(component_updater::ComponentUpdateService *),
Args = <const base::FilePath &, const base::Version &>]
      base::Bind(&RegisterPepperFlashWithChrome, path, version));
      ^
../../base/bind_helpers.h:468:8: note: template is declared here
struct MakeFunctionTypeImpl;
       ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:113:19:
error: use of undeclared identifier 'RegisterPepperFlashWithChrome'
      base::Bind(&RegisterPepperFlashWithChrome, path, version));
                  ^
3 errors generated.

.