cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

This CL modifies the existing cc ParamTraits perf test to
also perform the equivalent test using Mojo StructTraits,
and compares the two side by side.

This CL creates CompositorFrames with SolidColorDrawQuads
instead of PictureDrawQuads because PictureDrawQuads are
not serialized by other ParamTraits or StructTraits.

Finally, this CL renames CCParamTraitsPerfTest to
CCSerializationPerfTest to better capture what it does.

BUG=624459
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0409a7c70ee6087295121da095b5520c2fe14499
Committed: https://crrev.com/bb47aac79ed68f12f1a5514035b16ce91252133a
Cr-Original-Commit-Position: refs/heads/master@{#404011}
Cr-Commit-Position: refs/heads/master@{#404288}

[Fady Samuel, 2016-06-28 21:51:19]

Description was changed from

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

BUG=
==========

to

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-07-06 16:04:00]

Description was changed from

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

This CL modifies the existing cc ParamTraits perf test to
also perform the equivalent test using Mojo StructTraits,
and compares the two side by side.

This CL creates CompositorFrames with SolidColorDrawQuads 
instead of PictureDrawQuads because PictureDrawQuads are
not serialized by other ParamTraits or StructTraits.

Finally, this CL renames CCParamTraitsPerfTest to 
CCSerializationPerfTest to better capture what it does.

BUG=624459
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-07-06 16:05:15]

fsamuel@chromium.org changed reviewers:
+ danakj@chromium.org, dcheng@chromium.org, yzshen@chromium.org

[Fady Samuel, 2016-07-06 16:05:15]

+yzshen@ for StructTraits test review
+danakj@ for cc review
+dcheng@ for security review (this isn't really a security change but thought
you should take a look).

[yzshen1, 2016-07-06 17:11:57]

lgtm

https://codereview.chromium.org/2109863002/diff/60001/cc/ipc/cc_param_traits_...
File cc/ipc/cc_param_traits_perftest.cc (right):

https://codereview.chromium.org/2109863002/diff/60001/cc/ipc/cc_param_traits_...
cc/ipc/cc_param_traits_perftest.cc:125: const bool force_anti_aliasing_off =
true;
style nit: compile-time constants are named kLikeThis.

[Fady Samuel, 2016-07-06 17:25:48]

PTAL Dana and Daniel!

https://codereview.chromium.org/2109863002/diff/60001/cc/ipc/cc_param_traits_...
File cc/ipc/cc_param_traits_perftest.cc (right):

https://codereview.chromium.org/2109863002/diff/60001/cc/ipc/cc_param_traits_...
cc/ipc/cc_param_traits_perftest.cc:125: const bool force_anti_aliasing_off =
true;
On 2016/07/06 17:11:56, yzshen1 wrote:
> style nit: compile-time constants are named kLikeThis.

Done.

[Fady Samuel, 2016-07-06 17:25:53]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 17:27:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-07-06 18:26:38]

LGTM

https://codereview.chromium.org/2109863002/diff/80001/cc/ipc/BUILD.gn
File cc/ipc/BUILD.gn (right):

https://codereview.chromium.org/2109863002/diff/80001/cc/ipc/BUILD.gn#newcode21
cc/ipc/BUILD.gn:21: ":interfaces",
what is this? can you explain? it's not a path..

[Fady Samuel, 2016-07-06 18:40:05]

I'm CQ'ing. FYI dcheng@ although I don't think this needs security review
despite being in the ipc directory.

https://codereview.chromium.org/2109863002/diff/80001/cc/ipc/BUILD.gn
File cc/ipc/BUILD.gn (right):

https://codereview.chromium.org/2109863002/diff/80001/cc/ipc/BUILD.gn#newcode21
cc/ipc/BUILD.gn:21: ":interfaces",
On 2016/07/06 18:26:37, danakj wrote:
> what is this? can you explain? it's not a path..

This is an unnecessary change. Removed.

[Fady Samuel, 2016-07-06 18:40:14]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-07-06 18:40:14]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org,
danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2109863002/#ps100001
(title: "Cleanup")

[commit-bot: I haz the power, 2016-07-06 18:40:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 23:24:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 23:24:36]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Fady Samuel, 2016-07-06 23:27:47]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-07-06 23:28:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-07-07 00:29:07]

FWIW, I agree that this doesn't need my review =)

[commit-bot: I haz the power, 2016-07-07 00:29:48]

Description was changed from

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

This CL modifies the existing cc ParamTraits perf test to
also perform the equivalent test using Mojo StructTraits,
and compares the two side by side.

This CL creates CompositorFrames with SolidColorDrawQuads 
instead of PictureDrawQuads because PictureDrawQuads are
not serialized by other ParamTraits or StructTraits.

Finally, this CL renames CCParamTraitsPerfTest to 
CCSerializationPerfTest to better capture what it does.

BUG=624459
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

This CL modifies the existing cc ParamTraits perf test to
also perform the equivalent test using Mojo StructTraits,
and compares the two side by side.

This CL creates CompositorFrames with SolidColorDrawQuads 
instead of PictureDrawQuads because PictureDrawQuads are
not serialized by other ParamTraits or StructTraits.

Finally, this CL renames CCParamTraitsPerfTest to 
CCSerializationPerfTest to better capture what it does.

BUG=624459
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-07 00:29:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-07 00:30:03]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 00:31:08]

Description was changed from

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

This CL modifies the existing cc ParamTraits perf test to
also perform the equivalent test using Mojo StructTraits,
and compares the two side by side.

This CL creates CompositorFrames with SolidColorDrawQuads 
instead of PictureDrawQuads because PictureDrawQuads are
not serialized by other ParamTraits or StructTraits.

Finally, this CL renames CCParamTraitsPerfTest to 
CCSerializationPerfTest to better capture what it does.

BUG=624459
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

This CL modifies the existing cc ParamTraits perf test to
also perform the equivalent test using Mojo StructTraits,
and compares the two side by side.

This CL creates CompositorFrames with SolidColorDrawQuads
instead of PictureDrawQuads because PictureDrawQuads are
not serialized by other ParamTraits or StructTraits.

Finally, this CL renames CCParamTraitsPerfTest to
CCSerializationPerfTest to better capture what it does.

BUG=624459
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0409a7c70ee6087295121da095b5520c2fe14499
Cr-Commit-Position: refs/heads/master@{#404011}
==========

[commit-bot: I haz the power, 2016-07-07 00:31:09]

Patchset 6 (id:??) landed as
https://crrev.com/0409a7c70ee6087295121da095b5520c2fe14499
Cr-Commit-Position: refs/heads/master@{#404011}

[brucedawson, 2016-07-07 01:04:59]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2125833004/ by brucedawson@chromium.org.

The reason for reverting is: Compile error on Mac GYP (dbg) builds:

../../cc/ipc/cc_serialization_perftest.cc:10:10: fatal error:
'cc/ipc/compositor_frame.mojom.h' file not found
#include "cc/ipc/compositor_frame.mojom.h"

http://build.chromium.org/p/chromium.mac/builders/Mac%20GYP%20%28dbg%29/build...
.

[Fady Samuel, 2016-07-07 22:28:16]

Description was changed from

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

This CL modifies the existing cc ParamTraits perf test to
also perform the equivalent test using Mojo StructTraits,
and compares the two side by side.

This CL creates CompositorFrames with SolidColorDrawQuads
instead of PictureDrawQuads because PictureDrawQuads are
not serialized by other ParamTraits or StructTraits.

Finally, this CL renames CCParamTraitsPerfTest to
CCSerializationPerfTest to better capture what it does.

BUG=624459
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0409a7c70ee6087295121da095b5520c2fe14499
Cr-Commit-Position: refs/heads/master@{#404011}
==========

to

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

This CL modifies the existing cc ParamTraits perf test to
also perform the equivalent test using Mojo StructTraits,
and compares the two side by side.

This CL creates CompositorFrames with SolidColorDrawQuads
instead of PictureDrawQuads because PictureDrawQuads are
not serialized by other ParamTraits or StructTraits.

Finally, this CL renames CCParamTraitsPerfTest to
CCSerializationPerfTest to better capture what it does.

BUG=624459
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0409a7c70ee6087295121da095b5520c2fe14499
Cr-Commit-Position: refs/heads/master@{#404011}
==========

[Fady Samuel, 2016-07-07 22:28:28]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-07-07 22:28:29]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2109863002/#ps120001
(title: "Remove test from gyp")

[commit-bot: I haz the power, 2016-07-07 22:28:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 00:33:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 00:33:56]

Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)

[Fady Samuel, 2016-07-08 00:57:48]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-07-08 00:58:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 01:06:06]

Description was changed from

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

This CL modifies the existing cc ParamTraits perf test to
also perform the equivalent test using Mojo StructTraits,
and compares the two side by side.

This CL creates CompositorFrames with SolidColorDrawQuads
instead of PictureDrawQuads because PictureDrawQuads are
not serialized by other ParamTraits or StructTraits.

Finally, this CL renames CCParamTraitsPerfTest to
CCSerializationPerfTest to better capture what it does.

BUG=624459
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0409a7c70ee6087295121da095b5520c2fe14499
Cr-Commit-Position: refs/heads/master@{#404011}
==========

to

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

This CL modifies the existing cc ParamTraits perf test to
also perform the equivalent test using Mojo StructTraits,
and compares the two side by side.

This CL creates CompositorFrames with SolidColorDrawQuads
instead of PictureDrawQuads because PictureDrawQuads are
not serialized by other ParamTraits or StructTraits.

Finally, this CL renames CCParamTraitsPerfTest to
CCSerializationPerfTest to better capture what it does.

BUG=624459
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0409a7c70ee6087295121da095b5520c2fe14499
Cr-Commit-Position: refs/heads/master@{#404011}
==========

[commit-bot: I haz the power, 2016-07-08 01:06:07]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-08 01:06:24]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 01:09:16]

Description was changed from

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

This CL modifies the existing cc ParamTraits perf test to
also perform the equivalent test using Mojo StructTraits,
and compares the two side by side.

This CL creates CompositorFrames with SolidColorDrawQuads
instead of PictureDrawQuads because PictureDrawQuads are
not serialized by other ParamTraits or StructTraits.

Finally, this CL renames CCParamTraitsPerfTest to
CCSerializationPerfTest to better capture what it does.

BUG=624459
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0409a7c70ee6087295121da095b5520c2fe14499
Cr-Commit-Position: refs/heads/master@{#404011}
==========

to

==========
cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test

This CL modifies the existing cc ParamTraits perf test to
also perform the equivalent test using Mojo StructTraits,
and compares the two side by side.

This CL creates CompositorFrames with SolidColorDrawQuads
instead of PictureDrawQuads because PictureDrawQuads are
not serialized by other ParamTraits or StructTraits.

Finally, this CL renames CCParamTraitsPerfTest to
CCSerializationPerfTest to better capture what it does.

BUG=624459
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0409a7c70ee6087295121da095b5520c2fe14499
Committed: https://crrev.com/bb47aac79ed68f12f1a5514035b16ce91252133a
Cr-Original-Commit-Position: refs/heads/master@{#404011}
Cr-Commit-Position: refs/heads/master@{#404288}
==========

[commit-bot: I haz the power, 2016-07-08 01:09:17]

Patchset 7 (id:??) landed as
https://crrev.com/bb47aac79ed68f12f1a5514035b16ce91252133a
Cr-Commit-Position: refs/heads/master@{#404288}