Issue 2109843002: Add C++ wrappers for the wait set functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2109843002: Add C++ wrappers for the wait set functions. (Closed)

Created:
4 years, 5 months ago by viettrungluu

Modified:
4 years, 5 months ago

Reviewers:
azani

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add C++ wrappers for the wait set functions. I should also add some (at least cursory) tests, but I want to split core_unittest.cc before I do that. To do that, I really should split the test binary up. (Currently, I just include the new header wait_set.h from core_unittest.cc to make sure the it compiles.) R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d0d6e2f13ead7e5eb099e48977237ee21bb171f4

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -0 lines)			Patch
	M	mojo/public/cpp/system/tests/core_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	mojo/public/cpp/system/wait_set.h	View		1 chunk	+85 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

4 years, 5 months ago (2016-06-28 21:26:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d0d6e2f13ead7e5eb099e48977237ee21bb171f4 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages