Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing code review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
index 336f44b889db642d37cbb43319af71a2e94408bb..6d45967d231252a66012110c3f8bac6fa5297c77 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
@@ -60,6 +60,9 @@ WebInspector.NetworkManager = function(target)
this._bypassServiceWorkerSetting.addChangeListener(this._bypassServiceWorkerChanged, this);
WebInspector.moduleSetting("cacheDisabled").addChangeListener(this._cacheDisabledSettingChanged, this);
+
+ console.assert(!target[WebInspector.NetworkManager._symbol]);
+ target[WebInspector.NetworkManager._symbol] = this;
}
WebInspector.NetworkManager.EventTypes = {
@@ -81,6 +84,17 @@ WebInspector.NetworkManager._MIMETypes = {
"text/vtt": {"texttrack": true},
}
+WebInspector.NetworkManager._symbol = Symbol("NetworkManager");
+
+/**
+ * @param {!WebInspector.Target} target
+ * @return {?WebInspector.NetworkManager}
+ */
+WebInspector.NetworkManager.fromTarget = function(target)
+{
+ return target[WebInspector.NetworkManager._symbol] || null;
dgozman 2016/07/05 17:54:31 target.model(WebInspector.NetworkManager)
eostroukhov-old 2016/07/06 20:37:53 Done.
+}
+
/** @typedef {{download: number, upload: number, latency: number, title: string}} */
WebInspector.NetworkManager.Conditions;
/** @type {!WebInspector.NetworkManager.Conditions} */
@@ -134,7 +148,7 @@ WebInspector.NetworkManager.prototype = {
this._networkAgent.setCacheDisabled(enabled);
},
- dispose: function()
+ dispose: function(event)
dgozman 2016/07/05 17:54:31 Remove the parameter.
eostroukhov-old 2016/07/06 20:37:53 Done.
{
WebInspector.moduleSetting("cacheDisabled").removeChangeListener(this._cacheDisabledSettingChanged, this);
},

Powered by Google App Engine
This is Rietveld 408576698