Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
index 2ed32a58d6ec37bfe12517e033cd396cfc4e8744..b7adff6c1885afbedabbaef5939b731058e5ac68 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
@@ -1124,7 +1124,7 @@ WebInspector.NetworkRequest.prototype = {
initiatorRequest: function()
{
if (this._initiatorRequest === undefined)
- this._initiatorRequest = this.target().networkLog.requestForURL(this.initiatorInfo().url);
+ this._initiatorRequest = WebInspector.NetworkLog.fromTarget(this.target()).requestForURL(this.initiatorInfo().url);
dgozman 2016/06/30 17:24:33 this.networkLog()
eostroukhov-old 2016/06/30 21:38:28 Done.
return this._initiatorRequest;
},
@@ -1207,5 +1207,14 @@ WebInspector.NetworkRequest.prototype = {
this.target().networkAgent().replayXHR(this.requestId);
},
+ /**
+ * @return {!WebInspector.NetworkLog}
+ */
+ get networkLog()
dgozman 2016/06/30 17:24:33 Make it a function. Getters are banned, the remain
eostroukhov-old 2016/06/30 21:38:28 Done.
+ {
+ var networkLog = WebInspector.NetworkLog.fromTarget(this.target());
dgozman 2016/06/30 17:24:33 Let's instead save it into a field in constructor.
eostroukhov-old 2016/06/30 21:38:28 Done.
+ return console.assert(networkLog);
+ },
+
__proto__: WebInspector.SDKObject.prototype
}

Powered by Google App Engine
This is Rietveld 408576698