[DevTools] No NetworkManager and NetworkLog for v8only mode

third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
index ab95c758b722495ebcd2024430d717ca8197d62f..d3eac9c53c13ff9a6948cd3aae00018479392e02 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
@@ -60,6 +60,10 @@ WebInspector.NetworkManager = function(target)
     this._bypassServiceWorkerSetting.addChangeListener(this._bypassServiceWorkerChanged, this);
 
     WebInspector.moduleSetting("cacheDisabled").addChangeListener(this._cacheDisabledSettingChanged, this);
+
+    console.assert(!target[WebInspector.NetworkManager._symbol]);
+    target[WebInspector.NetworkManager._symbol] = this;
+    WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Events.TargetDisposed, this._targetDisposed, this);

[dgozman, 2016/06/30 17:24:33]

Hmm... It's strange this is a TargetManager's event, not Target's. Should we
change that?

[eostroukhov-old, 2016/06/30 21:38:28]

Discussed offline, nvm for now.

 }
 
 WebInspector.NetworkManager.EventTypes = {
@@ -81,6 +85,17 @@ WebInspector.NetworkManager._MIMETypes = {
     "text/vtt":                    {"texttrack": true},
 }
 
+WebInspector.NetworkManager._symbol = Symbol("NetworkManager");
+
+/**
+ * @param {!WebInspector.Target} target
+ * @return {?WebInspector.NetworkManager}
+ */
+WebInspector.NetworkManager.fromTarget = function(target)
+{
+    return target[WebInspector.NetworkManager._symbol] || null;
+}
+
 /** @typedef {{download: number, upload: number, latency: number, title: string}} */
 WebInspector.NetworkManager.Conditions;
 /** @type {!WebInspector.NetworkManager.Conditions} */
@@ -107,9 +122,14 @@ WebInspector.NetworkManager.prototype = {
         this._networkAgent.setCacheDisabled(enabled);
     },
 
-    dispose: function()
+    /**
+     * @param {!WebInspector.Event} event
+     */
+    _targetDisposed: function(event)

[dgozman, 2016/06/30 17:24:33]

I wonder whether we should put this functionality into SDKModel. Wouldn't hurt.

[eostroukhov-old, 2016/06/30 21:38:28]

Done.

     {
-        WebInspector.moduleSetting("cacheDisabled").removeChangeListener(this._cacheDisabledSettingChanged, this);
+        var target = /** @type {!WebInspector.Target} */ (event.data);
+        if (target === this._target)
+            WebInspector.moduleSetting("cacheDisabled").removeChangeListener(this._cacheDisabledSettingChanged, this);

[dgozman, 2016/06/30 17:24:32]

Please also do the same for DebuggerModel. Thanks!

[dgozman, 2016/06/30 17:24:33]

Please also remove the listener for TargetDisposed, or else network manager will
never be collected due to the reference from TargetManager.

[eostroukhov-old, 2016/06/30 21:38:28]

Done.

[eostroukhov-old, 2016/06/30 21:38:28]

Done.

     },
 
     /**