Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass NetworkManager as a ctor parameter, to ensure proper initialization order. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
index aa0b8dfd62d58117b45f49f117cc3fce17e59c3b..083a9137f125703605ff18a0a180e34035dcc68c 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
@@ -169,10 +169,11 @@ WebInspector.SecurityPanel.prototype = {
var originState = {};
originState.securityState = securityState;
+ var networkManager = WebInspector.NetworkManager.fromTarget(request.target());
var securityDetails = request.securityDetails();
- if (securityDetails) {
+ if (securityDetails && networkManager) {
originState.securityDetails = securityDetails;
- originState.certificateDetailsPromise = request.target().networkManager.certificateDetailsPromise(securityDetails.certificateId);
+ originState.certificateDetailsPromise = networkManager.certificateDetailsPromise(securityDetails.certificateId);
}
this._origins.set(origin, originState);
@@ -249,8 +250,12 @@ WebInspector.SecurityPanel.prototype = {
this._target = target;
target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._onMainFrameNavigated, this);
- target.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.ResponseReceived, this._onResponseReceived, this);
- target.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, this._onRequestFinished, this);
+ var networkManager = WebInspector.NetworkManager.fromTarget(target);
+ if (networkManager)
dgozman 2016/06/29 18:37:58 Page target must have a network manager. I wonder
eostroukhov-old 2016/06/29 22:54:21 For me it is not obvious that Elements tab always
+ {
dgozman 2016/06/29 18:37:58 style: { on the same line
eostroukhov-old 2016/06/29 22:54:21 Done.
+ networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.ResponseReceived, this._onResponseReceived, this);
+ networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, this._onRequestFinished, this);
+ }
var securityModel = WebInspector.SecurityModel.fromTarget(target);
securityModel.addEventListener(WebInspector.SecurityModel.EventTypes.SecurityStateChanged, this._onSecurityStateChanged, this);

Powered by Google App Engine
This is Rietveld 408576698