Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass NetworkManager as a ctor parameter, to ensure proper initialization order. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js b/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js
index 5219b8998c90b404a472dee6a66a5605ca3ac4a9..c98927928d61e3388093e1bf8fab453ad9d2ba6f 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js
@@ -66,7 +66,8 @@ WebInspector.HAREntry.prototype = {
if (this._request.connectionId !== "0")
entry.connection = this._request.connectionId;
- var page = this._request.target().networkLog.pageLoadForRequest(this._request);
+ var networkLog = WebInspector.NetworkLog.fromTarget(this._request.target());
+ var page = networkLog && networkLog.pageLoadForRequest(this._request);
dgozman 2016/06/29 18:37:57 I think we should have |this.networkLog()| in Netw
eostroukhov-old 2016/06/29 22:54:20 target() is inherited by NetworkRequest from the W
if (page)
entry.pageref = "page_" + page.id;
return entry;
@@ -328,7 +329,8 @@ WebInspector.HARLog.prototype = {
var pages = [];
for (var i = 0; i < this._requests.length; ++i) {
var request = this._requests[i];
- var page = request.target().networkLog.pageLoadForRequest(request);
+ var networkLog = WebInspector.NetworkLog.fromTarget(request.target());
+ var page = networkLog && networkLog.pageLoadForRequest(request);
if (!page || seenIdentifiers[page.id])
continue;
seenIdentifiers[page.id] = true;

Powered by Google App Engine
This is Rietveld 408576698