Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass NetworkManager as a ctor parameter, to ensure proper initialization order. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 36fcba3765cc5b1922d7e09bfcb10bb48f173a16..2307d902345660c2303e1dc2a71f4dd1be3377e7 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -211,7 +211,7 @@ WebInspector.NetworkLogView.prototype = {
target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.Load, this._loadEventFired, this);
target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.DOMContentLoaded, this._domContentLoadedEventFired, this);
}
- target.networkLog.requests().forEach(this._appendRequest.bind(this));
+ WebInspector.NetworkLog.fromTarget(target).requests().forEach(this._appendRequest.bind(this));
dgozman 2016/06/29 18:37:57 What if there is no network log for this target?
eostroukhov-old 2016/06/29 22:54:20 My thinking was to let exception be thrown... I ch
},
/**
@@ -1166,7 +1166,7 @@ WebInspector.NetworkLogView.prototype = {
// Pick provisional load requests.
var requestsToPick = [];
- var requests = frame.target().networkLog.requests();
+ var requests = WebInspector.NetworkLog.fromTarget(frame.target()).requests();
for (var i = 0; i < requests.length; ++i) {
var request = requests[i];
if (request.loaderId === loaderId)

Powered by Google App Engine
This is Rietveld 408576698