third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js - Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass NetworkManager as a ctor parameter, to ensure proper initialization order. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html » ('j') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

index f0dc4d7e5977c7ca6667f80f1a6eea81a1b85ded..1478546e64d4858cadf134d392f4f73c5df6b34e 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

@@ -971,9 +971,9 @@ WebInspector.targetManager.observeTargets({

InspectorTest.WorkerAgent = target.workerAgent();

InspectorTest.consoleModel = target.consoleModel;

- InspectorTest.networkManager = target.networkManager;

+ InspectorTest.networkManager = WebInspector.NetworkManager.fromTarget(target);

InspectorTest.resourceTreeModel = target.resourceTreeModel;

- InspectorTest.networkLog = target.networkLog;

+ InspectorTest.networkLog = WebInspector.NetworkLog.fromTarget(target);

InspectorTest.debuggerModel = WebInspector.DebuggerModel.fromTarget(target);

InspectorTest.runtimeModel = target.runtimeModel;

InspectorTest.domModel = WebInspector.DOMModel.fromTarget(target);