Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing code review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
index 51994bd45836a1a8bf30624777aca45b1700640e..7e09dff47441da4e36f267bab42c7633ea003b02 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
@@ -196,12 +196,16 @@ WebInspector.TargetManager.prototype = {
/** @type {!WebInspector.ConsoleModel} */
target.consoleModel = new WebInspector.ConsoleModel(target);
- /** @type {!WebInspector.NetworkManager} */
- target.networkManager = new WebInspector.NetworkManager(target);
+
+ var networkManager = null;
+ if (!target.isJSInspector())
+ networkManager = new WebInspector.NetworkManager(target);
+
/** @type {!WebInspector.ResourceTreeModel} */
- target.resourceTreeModel = new WebInspector.ResourceTreeModel(target);
- /** @type {!WebInspector.NetworkLog} */
- target.networkLog = new WebInspector.NetworkLog(target);
+ target.resourceTreeModel = new WebInspector.ResourceTreeModel(target, networkManager);
+
+ if (networkManager)
+ new WebInspector.NetworkLog(target, networkManager);
/** @type {!WebInspector.RuntimeModel} */
target.runtimeModel = new WebInspector.RuntimeModel(target);
@@ -214,7 +218,7 @@ WebInspector.TargetManager.prototype = {
}
/** @type {?WebInspector.WorkerManager} */
- target.workerManager = !target.isDedicatedWorker() ? new WebInspector.WorkerManager(target) : null;
+ target.workerManager = target.supportsWorkers() ? new WebInspector.WorkerManager(target) : null;
/** @type {!WebInspector.CPUProfilerModel} */
target.cpuProfilerModel = new WebInspector.CPUProfilerModel(target);
/** @type {!WebInspector.HeapProfilerModel} */

Powered by Google App Engine
This is Rietveld 408576698