Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing code review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
index 0539a60ab96e10b5eed5f5346626c7eb5c668dc4..8f5b5c556d952f8684ed0ecc65228cfba2d22711 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
@@ -32,13 +32,17 @@
* @constructor
* @extends {WebInspector.SDKModel}
* @param {!WebInspector.Target} target
+ * @param {?WebInspector.NetworkManager} networkManager
*/
-WebInspector.ResourceTreeModel = function(target)
+WebInspector.ResourceTreeModel = function(target, networkManager)
{
WebInspector.SDKModel.call(this, WebInspector.ResourceTreeModel, target);
-
- target.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, this._onRequestFinished, this);
- target.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestUpdateDropped, this._onRequestUpdateDropped, this);
+ if (networkManager) {
+ networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished,
+ this._onRequestFinished, this);
+ networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestUpdateDropped,
+ this._onRequestUpdateDropped, this);
+ }
this._agent = target.pageAgent();
this._agent.enable();

Powered by Google App Engine
This is Rietveld 408576698