Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The Chromium Authors. All rights reserved. 2 * Copyright 2014 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 /** 7 /**
8 * @constructor 8 * @constructor
9 * @extends {WebInspector.Object} 9 * @extends {WebInspector.Object}
10 */ 10 */
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 * @param {!InspectorBackendClass.Connection} connection 189 * @param {!InspectorBackendClass.Connection} connection
190 * @param {?WebInspector.Target} parentTarget 190 * @param {?WebInspector.Target} parentTarget
191 * @return {!WebInspector.Target} 191 * @return {!WebInspector.Target}
192 */ 192 */
193 createTarget: function(name, type, connection, parentTarget) 193 createTarget: function(name, type, connection, parentTarget)
194 { 194 {
195 var target = new WebInspector.Target(this, name, type, connection, paren tTarget); 195 var target = new WebInspector.Target(this, name, type, connection, paren tTarget);
196 196
197 /** @type {!WebInspector.ConsoleModel} */ 197 /** @type {!WebInspector.ConsoleModel} */
198 target.consoleModel = new WebInspector.ConsoleModel(target); 198 target.consoleModel = new WebInspector.ConsoleModel(target);
199 /** @type {!WebInspector.NetworkManager} */ 199
200 target.networkManager = new WebInspector.NetworkManager(target); 200 var networkManager = null;
201 if (!target.isJSInspector()) {
dgozman 2016/06/30 17:24:33 style: extra {}
eostroukhov-old 2016/06/30 21:38:28 Done.
202 networkManager = new WebInspector.NetworkManager(target);
203 }
204
201 /** @type {!WebInspector.ResourceTreeModel} */ 205 /** @type {!WebInspector.ResourceTreeModel} */
202 target.resourceTreeModel = new WebInspector.ResourceTreeModel(target); 206 target.resourceTreeModel = new WebInspector.ResourceTreeModel(target, ne tworkManager);
203 /** @type {!WebInspector.NetworkLog} */ 207
204 target.networkLog = new WebInspector.NetworkLog(target); 208 if (networkManager) {
dgozman 2016/06/30 17:24:33 ditto
eostroukhov-old 2016/06/30 21:38:28 Done.
209 new WebInspector.NetworkLog(target, networkManager);
210 }
205 211
206 /** @type {!WebInspector.RuntimeModel} */ 212 /** @type {!WebInspector.RuntimeModel} */
207 target.runtimeModel = new WebInspector.RuntimeModel(target); 213 target.runtimeModel = new WebInspector.RuntimeModel(target);
208 if (target.hasJSContext()) 214 if (target.hasJSContext())
209 new WebInspector.DebuggerModel(target); 215 new WebInspector.DebuggerModel(target);
210 216
211 if (target.type() === WebInspector.Target.Type.Page) { 217 if (target.type() === WebInspector.Target.Type.Page) {
212 new WebInspector.DOMModel(target); 218 new WebInspector.DOMModel(target);
213 new WebInspector.CSSModel(target); 219 new WebInspector.CSSModel(target);
214 } 220 }
215 221
216 /** @type {?WebInspector.WorkerManager} */ 222 /** @type {?WebInspector.WorkerManager} */
217 target.workerManager = !target.isDedicatedWorker() ? new WebInspector.Wo rkerManager(target) : null; 223 target.workerManager = target.supportsWorkers() ? new WebInspector.Worke rManager(target) : null;
218 /** @type {!WebInspector.CPUProfilerModel} */ 224 /** @type {!WebInspector.CPUProfilerModel} */
219 target.cpuProfilerModel = new WebInspector.CPUProfilerModel(target); 225 target.cpuProfilerModel = new WebInspector.CPUProfilerModel(target);
220 /** @type {!WebInspector.HeapProfilerModel} */ 226 /** @type {!WebInspector.HeapProfilerModel} */
221 target.heapProfilerModel = new WebInspector.HeapProfilerModel(target); 227 target.heapProfilerModel = new WebInspector.HeapProfilerModel(target);
222 228
223 target.tracingManager = new WebInspector.TracingManager(target); 229 target.tracingManager = new WebInspector.TracingManager(target);
224 230
225 if (target.isPage()) 231 if (target.isPage())
226 target.serviceWorkerManager = new WebInspector.ServiceWorkerManager( target); 232 target.serviceWorkerManager = new WebInspector.ServiceWorkerManager( target);
227 233
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 /** 382 /**
377 * @param {!WebInspector.Target} target 383 * @param {!WebInspector.Target} target
378 */ 384 */
379 targetRemoved: function(target) { }, 385 targetRemoved: function(target) { },
380 } 386 }
381 387
382 /** 388 /**
383 * @type {!WebInspector.TargetManager} 389 * @type {!WebInspector.TargetManager}
384 */ 390 */
385 WebInspector.targetManager = new WebInspector.TargetManager(); 391 WebInspector.targetManager = new WebInspector.TargetManager();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698