[DevTools] No NetworkManager and NetworkLog for v8only mode

third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 42 matching lines @@
 
     /** @type {!Map<!SecurityAgent.CertificateId, !Promise<!NetworkAgent.CertificateDetails>>} */
     this._certificateDetailsCache = new Map();
 
     this._bypassServiceWorkerSetting = WebInspector.settings.createSetting("bypassServiceWorker", false);
     if (this._bypassServiceWorkerSetting.get())
         this._bypassServiceWorkerChanged();
     this._bypassServiceWorkerSetting.addChangeListener(this._bypassServiceWorkerChanged, this);
 
     WebInspector.moduleSetting("cacheDisabled").addChangeListener(this._cacheDisabledSettingChanged, this);
+
+    console.assert(!target[WebInspector.NetworkManager._symbol]);
+    target[WebInspector.NetworkManager._symbol] = this;
+    WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Events.TargetDisposed, this._targetDisposed, this);

[dgozman, 2016/06/30 17:24:33]

Hmm... It's strange this is a TargetManager's event, not Target's. Should we
change that?

[eostroukhov-old, 2016/06/30 21:38:28]

Discussed offline, nvm for now.

 }
 
 WebInspector.NetworkManager.EventTypes = {
     RequestStarted: "RequestStarted",
     RequestUpdated: "RequestUpdated",
     RequestFinished: "RequestFinished",
     RequestUpdateDropped: "RequestUpdateDropped",
     ResponseReceived: "ResponseReceived"
 }
 
 WebInspector.NetworkManager._MIMETypes = {
     "text/html":                   {"document": true},
     "text/xml":                    {"document": true},
     "text/plain":                  {"document": true},
     "application/xhtml+xml":       {"document": true},
     "image/svg+xml":               {"document": true},
     "text/css":                    {"stylesheet": true},
     "text/xsl":                    {"stylesheet": true},
     "text/vtt":                    {"texttrack": true},
 }
 
+WebInspector.NetworkManager._symbol = Symbol("NetworkManager");
+
+/**
+ * @param {!WebInspector.Target} target
+ * @return {?WebInspector.NetworkManager}
+ */
+WebInspector.NetworkManager.fromTarget = function(target)
+{
+    return target[WebInspector.NetworkManager._symbol] || null;
+}
+
 /** @typedef {{download: number, upload: number, latency: number, title: string}} */
 WebInspector.NetworkManager.Conditions;
 /** @type {!WebInspector.NetworkManager.Conditions} */
 WebInspector.NetworkManager.NoThrottlingConditions = {title: WebInspector.UIString("No throttling"), download: -1, upload: -1, latency: 0};
 /** @type {!WebInspector.NetworkManager.Conditions} */
 WebInspector.NetworkManager.OfflineConditions = {title: WebInspector.UIString("Offline"), download: 0, upload: 0, latency: 0};
 
 WebInspector.NetworkManager.prototype = {
     /**
      * @param {string} url
      * @return {!WebInspector.NetworkRequest}
      */
     inflightRequestForURL: function(url)
     {
         return this._dispatcher._inflightRequestsByURL[url];
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _cacheDisabledSettingChanged: function(event)
     {
         var enabled = /** @type {boolean} */ (event.data);
         this._networkAgent.setCacheDisabled(enabled);
     },
 
-    dispose: function()
+    /**
+     * @param {!WebInspector.Event} event
+     */
+    _targetDisposed: function(event)

[dgozman, 2016/06/30 17:24:33]

I wonder whether we should put this functionality into SDKModel. Wouldn't hurt.

[eostroukhov-old, 2016/06/30 21:38:28]

Done.

     {
-        WebInspector.moduleSetting("cacheDisabled").removeChangeListener(this._cacheDisabledSettingChanged, this);
+        var target = /** @type {!WebInspector.Target} */ (event.data);
+        if (target === this._target)
+            WebInspector.moduleSetting("cacheDisabled").removeChangeListener(this._cacheDisabledSettingChanged, this);

[dgozman, 2016/06/30 17:24:32]

Please also do the same for DebuggerModel. Thanks!

[dgozman, 2016/06/30 17:24:33]

Please also remove the listener for TargetDisposed, or else network manager will
never be collected due to the reference from TargetManager.

[eostroukhov-old, 2016/06/30 21:38:28]

Done.

[eostroukhov-old, 2016/06/30 21:38:28]

Done.

     },
 
     /**
      * @param {!SecurityAgent.CertificateId} certificateId
      * @return {!Promise<!NetworkAgent.CertificateDetails>}
      */
     certificateDetailsPromise: function(certificateId)
     {
         var cachedPromise = this._certificateDetailsCache.get(certificateId);
         if (cachedPromise)
@@ skipping 784 matching lines @@
         WebInspector.ResourceLoader.load(url, headers, callback);
     },
 
     __proto__: WebInspector.Object.prototype
 }
 
 /**
  * @type {!WebInspector.MultitargetNetworkManager}
  */
 WebInspector.multitargetNetworkManager;