[DevTools] No NetworkManager and NetworkLog for v8only mode

third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.PanelWithSidebar}
  * @implements {WebInspector.TargetManager.Observer}
  */
 WebInspector.SecurityPanel = function()
@@ skipping 151 matching lines @@
             if (oldSecurityState !== originState.securityState) {
                 this._sidebarTree.updateOrigin(origin, securityState);
                 if (originState.originView)
                     originState.originView.setSecurityState(securityState);
             }
         } else {
             // TODO(lgarron): Store a (deduplicated) list of different security details we have seen. https://crbug.com/503170
             var originState = {};
             originState.securityState = securityState;
 
+            var networkManager = WebInspector.NetworkManager.fromTarget(request.target());
             var securityDetails = request.securityDetails();
-            if (securityDetails) {
+            if (securityDetails && networkManager) {
                 originState.securityDetails = securityDetails;
-                originState.certificateDetailsPromise = request.target().networkManager.certificateDetailsPromise(securityDetails.certificateId);
+                originState.certificateDetailsPromise = networkManager.certificateDetailsPromise(securityDetails.certificateId);
             }
 
             this._origins.set(origin, originState);
 
             this._sidebarTree.addOrigin(origin, securityState);
 
             // Don't construct the origin view yet (let it happen lazily).
         }
     },
 
@@ skipping 56 matching lines @@
      * @param {!WebInspector.Target} target
      */
     targetAdded: function(target)
     {
         if (this._target)
             return;
 
         this._target = target;
 
         target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._onMainFrameNavigated, this);
-        target.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.ResponseReceived, this._onResponseReceived, this);
-        target.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, this._onRequestFinished, this);
+        var networkManager = WebInspector.NetworkManager.fromTarget(target);
+        if (networkManager)

[dgozman, 2016/06/29 18:37:58]

Page target must have a network manager. I wonder how we can make this better...

[eostroukhov-old, 2016/06/29 22:54:21]

For me it is not obvious that Elements tab always means you should have a
Network tab... I think it is ok to allow page targets without network.

+        {

[dgozman, 2016/06/29 18:37:58]

style: { on the same line

[eostroukhov-old, 2016/06/29 22:54:21]

Done.

+            networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.ResponseReceived, this._onResponseReceived, this);
+            networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, this._onRequestFinished, this);
+        }
 
         var securityModel = WebInspector.SecurityModel.fromTarget(target);
         securityModel.addEventListener(WebInspector.SecurityModel.EventTypes.SecurityStateChanged, this._onSecurityStateChanged, this);
     },
 
     /**
      * @override
      * @param {!WebInspector.Target} target
      */
     targetRemoved: function(target)
@@ skipping 672 matching lines @@
         row.createChild("div").textContent = key;
 
         var valueDiv = row.createChild("div");
         if (typeof value === "string") {
             valueDiv.textContent = value;
         } else {
             valueDiv.appendChild(value);
         }
     }
 }