Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass NetworkManager as a ctor parameter, to ensure proper initialization order. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The Chromium Authors. All rights reserved. 2 * Copyright 2014 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 /** 7 /**
8 * @constructor 8 * @constructor
9 * @extends {WebInspector.Object} 9 * @extends {WebInspector.Object}
10 */ 10 */
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 * @param {!InspectorBackendClass.Connection} connection 189 * @param {!InspectorBackendClass.Connection} connection
190 * @param {?WebInspector.Target} parentTarget 190 * @param {?WebInspector.Target} parentTarget
191 * @return {!WebInspector.Target} 191 * @return {!WebInspector.Target}
192 */ 192 */
193 createTarget: function(name, type, connection, parentTarget) 193 createTarget: function(name, type, connection, parentTarget)
194 { 194 {
195 var target = new WebInspector.Target(this, name, type, connection, paren tTarget); 195 var target = new WebInspector.Target(this, name, type, connection, paren tTarget);
196 196
197 /** @type {!WebInspector.ConsoleModel} */ 197 /** @type {!WebInspector.ConsoleModel} */
198 target.consoleModel = new WebInspector.ConsoleModel(target); 198 target.consoleModel = new WebInspector.ConsoleModel(target);
199 /** @type {!WebInspector.NetworkManager} */ 199
200 target.networkManager = new WebInspector.NetworkManager(target); 200 var networkManager = null;
201 if (!target.isV8Inspector()) {
dgozman 2016/06/29 18:37:58 style: extra {}
eostroukhov-old 2016/06/29 22:54:21 Done.
202 networkManager = new WebInspector.NetworkManager(target);
203 }
204
201 /** @type {!WebInspector.ResourceTreeModel} */ 205 /** @type {!WebInspector.ResourceTreeModel} */
202 target.resourceTreeModel = new WebInspector.ResourceTreeModel(target); 206 target.resourceTreeModel = new WebInspector.ResourceTreeModel(target, ne tworkManager);
203 /** @type {!WebInspector.NetworkLog} */ 207
204 target.networkLog = new WebInspector.NetworkLog(target); 208 if (networkManager) {
209 new WebInspector.NetworkLog(target, networkManager);
210 }
205 211
206 /** @type {!WebInspector.RuntimeModel} */ 212 /** @type {!WebInspector.RuntimeModel} */
207 target.runtimeModel = new WebInspector.RuntimeModel(target); 213 target.runtimeModel = new WebInspector.RuntimeModel(target);
208 if (target.hasJSContext()) 214 if (target.hasJSContext())
209 new WebInspector.DebuggerModel(target); 215 new WebInspector.DebuggerModel(target);
210 216
211 if (target.type() === WebInspector.Target.Type.Page) { 217 if (target.type() === WebInspector.Target.Type.Page) {
212 new WebInspector.DOMModel(target); 218 new WebInspector.DOMModel(target);
213 new WebInspector.CSSModel(target); 219 new WebInspector.CSSModel(target);
214 } 220 }
215 221
216 /** @type {?WebInspector.WorkerManager} */ 222 /** @type {?WebInspector.WorkerManager} */
217 target.workerManager = !target.isDedicatedWorker() ? new WebInspector.Wo rkerManager(target) : null; 223 target.workerManager =
224 target.isDedicatedWorker() || target.isV8Inspector() ? null : new We bInspector.WorkerManager(target);
dgozman 2016/06/29 18:37:58 Let's introduce Target.supportsWorkers().
eostroukhov-old 2016/06/29 22:54:21 Done.
218 /** @type {!WebInspector.CPUProfilerModel} */ 225 /** @type {!WebInspector.CPUProfilerModel} */
219 target.cpuProfilerModel = new WebInspector.CPUProfilerModel(target); 226 target.cpuProfilerModel = new WebInspector.CPUProfilerModel(target);
220 /** @type {!WebInspector.HeapProfilerModel} */ 227 /** @type {!WebInspector.HeapProfilerModel} */
221 target.heapProfilerModel = new WebInspector.HeapProfilerModel(target); 228 target.heapProfilerModel = new WebInspector.HeapProfilerModel(target);
222 229
223 target.tracingManager = new WebInspector.TracingManager(target); 230 target.tracingManager = new WebInspector.TracingManager(target);
224 231
225 if (target.isPage()) 232 if (target.isPage())
226 target.serviceWorkerManager = new WebInspector.ServiceWorkerManager( target); 233 target.serviceWorkerManager = new WebInspector.ServiceWorkerManager( target);
227 234
(...skipping 13 matching lines...) Expand all
241 result.push(observer); 248 result.push(observer);
242 } 249 }
243 return result; 250 return result;
244 }, 251 },
245 252
246 /** 253 /**
247 * @param {!WebInspector.Target} target 254 * @param {!WebInspector.Target} target
248 */ 255 */
249 addTarget: function(target) 256 addTarget: function(target)
250 { 257 {
258 console.assert(target);
dgozman 2016/06/29 18:37:58 Remove?
eostroukhov-old 2016/06/29 22:54:20 Done.
251 this._targets.push(target); 259 this._targets.push(target);
252 if (this._targets.length === 1) { 260 if (this._targets.length === 1) {
253 target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeM odel.EventTypes.InspectedURLChanged, this._redispatchEvent, this); 261 target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeM odel.EventTypes.InspectedURLChanged, this._redispatchEvent, this);
254 target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeM odel.EventTypes.MainFrameNavigated, this._redispatchEvent, this); 262 target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeM odel.EventTypes.MainFrameNavigated, this._redispatchEvent, this);
255 target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeM odel.EventTypes.Load, this._redispatchEvent, this); 263 target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeM odel.EventTypes.Load, this._redispatchEvent, this);
256 target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeM odel.EventTypes.PageReloadRequested, this._redispatchEvent, this); 264 target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeM odel.EventTypes.PageReloadRequested, this._redispatchEvent, this);
257 target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeM odel.EventTypes.WillReloadPage, this._redispatchEvent, this); 265 target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeM odel.EventTypes.WillReloadPage, this._redispatchEvent, this);
258 } 266 }
259 var copy = this._observersByType(target.type()); 267 var copy = this._observersByType(target.type());
260 for (var i = 0; i < copy.length; ++i) 268 for (var i = 0; i < copy.length; ++i)
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 /** 384 /**
377 * @param {!WebInspector.Target} target 385 * @param {!WebInspector.Target} target
378 */ 386 */
379 targetRemoved: function(target) { }, 387 targetRemoved: function(target) { },
380 } 388 }
381 389
382 /** 390 /**
383 * @type {!WebInspector.TargetManager} 391 * @type {!WebInspector.TargetManager}
384 */ 392 */
385 WebInspector.targetManager = new WebInspector.TargetManager(); 393 WebInspector.targetManager = new WebInspector.TargetManager();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698