[DevTools] No NetworkManager and NetworkLog for v8only mode

third_party/WebKit/Source/devtools/front_end/sdk/Target.js

 /*
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * @constructor
  * @extends {Protocol.Agents}
  * @param {!WebInspector.TargetManager} targetManager
  * @param {string} name
  * @param {number} type
  * @param {!InspectorBackendClass.Connection} connection
  * @param {?WebInspector.Target} parentTarget
  */
 WebInspector.Target = function(targetManager, name, type, connection, parentTarget)
 {
     Protocol.Agents.call(this, connection.agentsMap());
     this._targetManager = targetManager;
     this._name = name;
     this._type = type;
     this._connection = connection;
     this._parentTarget = parentTarget;
     connection.addEventListener(InspectorBackendClass.Connection.Events.Disconnected, this._onDisconnect, this);
     this._id = WebInspector.Target._nextId++;
 
     /** @type {!Map.<!Function, !WebInspector.SDKModel>} */
     this._modelByConstructor = new Map();
+    /** @type {!Array<!{dispose: !Function}>} */

[dgozman, 2016/06/29 18:37:58]

If we go for this, Disposable should be an interface.

[eostroukhov-old, 2016/06/29 22:54:20]

Removed the array, listening to an event instead.

+    this.disposables = [];
 }
 
 /**
  * @enum {number}
  */
 WebInspector.Target.Type = {
     Page: 1,
     DedicatedWorker: 2,
-    ServiceWorker: 4
+    ServiceWorker: 4,
+    V8Inspector: 8

[dgozman, 2016/06/29 18:37:58]

I think it's better to use JS term instead of V8. But we already have "v8Only".
Let's add a TODO to rename them.

[eostroukhov-old, 2016/06/29 22:54:20]

Done.

 }
 
 WebInspector.Target._nextId = 1;
 
 WebInspector.Target.prototype = {
     /**
      * @return {number}
      */
     id: function()
     {
@@ skipping 51 matching lines @@
     isPage: function()
     {
         return this._type === WebInspector.Target.Type.Page;
     },
 
     /**
      * @return {boolean}
      */
     isWorker: function()
     {
-        return this.isDedicatedWorker() || this.isServiceWorker();
+        return this.isDedicatedWorker() || this.isServiceWorker() || this.isV8Inspector();
     },
 
     /**
      * @return {boolean}
      */
     isDedicatedWorker: function()
     {
         return this._type === WebInspector.Target.Type.DedicatedWorker;
     },
 
     /**
      * @return {boolean}
      */
     isServiceWorker: function()
     {
         return this._type === WebInspector.Target.Type.ServiceWorker;
     },
 
     /**
      * @return {boolean}
      */
+    isV8Inspector: function()
+    {
+        return this._type === WebInspector.Target.Type.V8Inspector;
+    },
+
+    /**
+     * @return {boolean}
+     */
     hasJSContext: function()
     {
         return !this.isServiceWorker();
     },
 
     /**
      * @return {?WebInspector.Target}
      */
     parentTarget: function()
     {
         return this._parentTarget;
     },
 
     _onDisconnect: function()
     {
         this._targetManager.removeTarget(this);
         this._dispose();
     },
 
     _dispose: function()
     {
         this._targetManager.dispatchEventToListeners(WebInspector.TargetManager.Events.TargetDisposed, this);
-        this.networkManager.dispose();
         this.cpuProfilerModel.dispose();
         WebInspector.ServiceWorkerCacheModel.fromTarget(this).dispose();
         if (this.workerManager)
             this.workerManager.dispose();
+        for (var disposable of this.disposables)

[dgozman, 2016/06/29 18:37:58]

I think we can just listen for TargetDisposed event, and remove the listener
there to avoid a reference for GC?

[eostroukhov-old, 2016/06/29 22:54:20]

Done.

+            disposable.dispose();
     },
 
     /**
      * @return {boolean}
      */
     isDetached: function()
     {
         return this._connection.isClosed();
     },
 
@@ skipping 64 matching lines @@
     /**
      * @return {!Promise}
      */
     resumeModel: function()
     {
         return Promise.resolve();
     },
 
     __proto__: WebInspector.SDKObject.prototype
 }