Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing code review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.PanelWithSidebar} 7 * @extends {WebInspector.PanelWithSidebar}
8 * @implements {WebInspector.TargetManager.Observer} 8 * @implements {WebInspector.TargetManager.Observer}
9 */ 9 */
10 WebInspector.SecurityPanel = function() 10 WebInspector.SecurityPanel = function()
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 originState.originView.setSecurityState(securityState); 165 originState.originView.setSecurityState(securityState);
166 } 166 }
167 } else { 167 } else {
168 // TODO(lgarron): Store a (deduplicated) list of different security details we have seen. https://crbug.com/503170 168 // TODO(lgarron): Store a (deduplicated) list of different security details we have seen. https://crbug.com/503170
169 var originState = {}; 169 var originState = {};
170 originState.securityState = securityState; 170 originState.securityState = securityState;
171 171
172 var securityDetails = request.securityDetails(); 172 var securityDetails = request.securityDetails();
173 if (securityDetails) { 173 if (securityDetails) {
174 originState.securityDetails = securityDetails; 174 originState.securityDetails = securityDetails;
175 originState.certificateDetailsPromise = request.target().network Manager.certificateDetailsPromise(securityDetails.certificateId); 175 originState.certificateDetailsPromise = request.networkManager() .certificateDetailsPromise(securityDetails.certificateId);
176 } 176 }
177 177
178 this._origins.set(origin, originState); 178 this._origins.set(origin, originState);
179 179
180 this._sidebarTree.addOrigin(origin, securityState); 180 this._sidebarTree.addOrigin(origin, securityState);
181 181
182 // Don't construct the origin view yet (let it happen lazily). 182 // Don't construct the origin view yet (let it happen lazily).
183 } 183 }
184 }, 184 },
185 185
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 * @param {!WebInspector.Target} target 242 * @param {!WebInspector.Target} target
243 */ 243 */
244 targetAdded: function(target) 244 targetAdded: function(target)
245 { 245 {
246 if (this._target) 246 if (this._target)
247 return; 247 return;
248 248
249 this._target = target; 249 this._target = target;
250 250
251 target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel .EventTypes.MainFrameNavigated, this._onMainFrameNavigated, this); 251 target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel .EventTypes.MainFrameNavigated, this._onMainFrameNavigated, this);
252 target.networkManager.addEventListener(WebInspector.NetworkManager.Event Types.ResponseReceived, this._onResponseReceived, this); 252 var networkManager = WebInspector.NetworkManager.fromTarget(target);
253 target.networkManager.addEventListener(WebInspector.NetworkManager.Event Types.RequestFinished, this._onRequestFinished, this); 253 if (networkManager) {
254 networkManager.addEventListener(WebInspector.NetworkManager.EventTyp es.ResponseReceived, this._onResponseReceived, this);
255 networkManager.addEventListener(WebInspector.NetworkManager.EventTyp es.RequestFinished, this._onRequestFinished, this);
256 }
254 257
255 var securityModel = WebInspector.SecurityModel.fromTarget(target); 258 var securityModel = WebInspector.SecurityModel.fromTarget(target);
256 securityModel.addEventListener(WebInspector.SecurityModel.EventTypes.Sec urityStateChanged, this._onSecurityStateChanged, this); 259 securityModel.addEventListener(WebInspector.SecurityModel.EventTypes.Sec urityStateChanged, this._onSecurityStateChanged, this);
257 }, 260 },
258 261
259 /** 262 /**
260 * @override 263 * @override
261 * @param {!WebInspector.Target} target 264 * @param {!WebInspector.Target} target
262 */ 265 */
263 targetRemoved: function(target) 266 targetRemoved: function(target)
(...skipping 725 matching lines...) Expand 10 before | Expand all | Expand 10 after
989 row.createChild("div").textContent = key; 992 row.createChild("div").textContent = key;
990 993
991 var valueDiv = row.createChild("div"); 994 var valueDiv = row.createChild("div");
992 if (typeof value === "string") { 995 if (typeof value === "string") {
993 valueDiv.textContent = value; 996 valueDiv.textContent = value;
994 } else { 997 } else {
995 valueDiv.appendChild(value); 998 valueDiv.appendChild(value);
996 } 999 }
997 } 1000 }
998 } 1001 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698