Add support for EXT_image_flush_external extension

ui/gl/gl_image_ozone_native_pixmap.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/buffer_format_util.h"
+#include "ui/gl/gl_fence.h"
 #include "ui/gl/gl_image_ozone_native_pixmap.h"
 #include "ui/gl/gl_surface_egl.h"
 
 #define FOURCC(a, b, c, d)                                        \
   ((static_cast<uint32_t>(a)) | (static_cast<uint32_t>(b) << 8) | \
    (static_cast<uint32_t>(c) << 16) | (static_cast<uint32_t>(d) << 24))
 
 #define DRM_FORMAT_R8 FOURCC('R', '8', ' ', ' ')
 #define DRM_FORMAT_RGB565 FOURCC('R', 'G', '1', '6')
 #define DRM_FORMAT_ARGB8888 FOURCC('A', 'R', '2', '4')
@@ skipping 181 matching lines @@
   return GLImageEGL::CopyTexImage(target);
 }
 
 bool GLImageOzoneNativePixmap::ScheduleOverlayPlane(
     gfx::AcceleratedWidget widget,
     int z_order,
     gfx::OverlayTransform transform,
     const gfx::Rect& bounds_rect,
     const gfx::RectF& crop_rect) {
   DCHECK(pixmap_);
+

[reveman, 2016/07/11 18:59:06]

nit: no need to add this blank line

   return pixmap_->ScheduleOverlayPlane(widget, z_order, transform, bounds_rect,
                                        crop_rect);
 }
 
 void GLImageOzoneNativePixmap::OnMemoryDump(
     base::trace_event::ProcessMemoryDump* pmd,
     uint64_t process_tracing_id,
     const std::string& dump_name) {
   // TODO(ericrk): Implement GLImage OnMemoryDump. crbug.com/514914
 }
@@ skipping 23 matching lines @@
     case gfx::BufferFormat::YUV_420_BIPLANAR:
     case gfx::BufferFormat::UYVY_422:
       NOTREACHED();
       return GL_NONE;
   }
 
   NOTREACHED();
   return GL_NONE;
 }
 
+void GLImageOzoneNativePixmap::Flush() {

[reveman, 2016/07/11 18:59:06]

nit: move below ScheduleOverlayPlane

+  if (GLSurfaceEGL::HasEGLExtension("EGL_EXT_image_flush_external")) {

[piman, 2016/07/11 16:06:26]

nit: parsing strings on every frame seems a bit unfortunate. Can we check this
at creation time and keep in a field?

+    EGLDisplay display = GLSurfaceEGL::GetHardwareDisplay();
+    const EGLAttrib attribs[] = {
+        EGL_NONE,
+    };
+    if (!eglImageFlushExternalEXT(display, egl_image_, attribs)) {
+      LOG(ERROR) << "Failed to flush rendering";
+      return;
+    }
+  }
+
+  return;

[reveman, 2016/07/11 18:59:06]

nit: remove unnecessary return statement

+}
+
 }  // namespace gl