Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: net/quic/quic_network_transaction_unittest.cc

Issue 2109803002: Change a number of SPDY unittests from http to https. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_request_unittest.cc ('k') | net/spdy/spdy_http_stream_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_network_transaction_unittest.cc
diff --git a/net/quic/quic_network_transaction_unittest.cc b/net/quic/quic_network_transaction_unittest.cc
index fb3eb494e25ea0e966df965a842f6963d4eb116d..7460a51eb7253ab7a5a640f90cd714ca15344ce4 100644
--- a/net/quic/quic_network_transaction_unittest.cc
+++ b/net/quic/quic_network_transaction_unittest.cc
@@ -267,8 +267,6 @@ class QuicNetworkTransactionTest
request_.load_flags = 0;
clock_->AdvanceTime(QuicTime::Delta::FromMilliseconds(20));
- params_.enable_alternative_service_for_insecure_origins = true;
-
scoped_refptr<X509Certificate> cert(
ImportCertFromFile(GetTestCertsDirectory(), "wildcard.pem"));
verify_details_.cert_verify_result.verified_cert = cert;
@@ -1011,19 +1009,19 @@ TEST_P(QuicNetworkTransactionTest, SetAlternativeServiceWithScheme) {
socket_factory_.AddSSLSocketDataProvider(&ssl_data_);
CreateSession();
- // Send http request, ignore alternative service advertising if response
+ // Send https request, ignore alternative service advertising if response
// header advertises alternative service for mail.example.org.
- request_.url = GURL("http://mail.example.org:443");
+ request_.url = GURL("https://mail.example.org:443");
SendRequestAndExpectHttpResponse("hello world");
HttpServerProperties* http_server_properties =
session_->http_server_properties();
url::SchemeHostPort http_server("http", "mail.example.org", 443);
url::SchemeHostPort https_server("https", "mail.example.org", 443);
// Check alternative service is set for the correct origin.
- EXPECT_EQ(2u,
- http_server_properties->GetAlternativeServices(http_server).size());
EXPECT_EQ(
- 0u, http_server_properties->GetAlternativeServices(https_server).size());
+ 2u, http_server_properties->GetAlternativeServices(https_server).size());
+ EXPECT_TRUE(
+ http_server_properties->GetAlternativeServices(http_server).empty());
}
TEST_P(QuicNetworkTransactionTest, DoNotGetAltSvcForDifferentOrigin) {
« no previous file with comments | « net/http/http_stream_factory_impl_request_unittest.cc ('k') | net/spdy/spdy_http_stream_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698