GLVersionInfo: for ES3 check for sampler array indexing

GLVersionInfo: for ES3 check for sampler array indexing

Index-constant sampler array indexing is a required feature for OpenGL
ES2 however some drivers silently support it and we can't gate OpenGL
ES2 support on GL_ARB_gpu_shader5 being present. That's why we only
enforce this feature for ES3.

BUG=598902
Committed: https://crrev.com/cf7b555abc38ee52485c0bbd0ae09a672f3348ce
Cr-Commit-Position: refs/heads/master@{#402719}

[Corentin Wallez, 2016-06-28 19:24:03]

cwallez@chromium.org changed reviewers:
+ kbr@chromium.org, piman@chromium.org, zmo@chromium.org

[Corentin Wallez, 2016-06-28 19:24:24]

cwallez@chromium.org changed reviewers:
- piman@chromium.org

[Corentin Wallez, 2016-06-28 19:24:25]

PTAL

[Zhenyao Mo, 2016-06-28 21:43:27]

LGTM

https://codereview.chromium.org/2109773003/diff/1/ui/gl/gl_version_info.cc
File ui/gl/gl_version_info.cc (right):

https://codereview.chromium.org/2109773003/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:96: bool has_sampler_indexing = IsAtLeastGL(4, 0) ||
IsAtLeastGLES(2, 0) ||
nit: IsAtLeastGLES(2, 0) can be is_es, which is clearer.

[Corentin Wallez, 2016-06-28 21:46:01]

On 2016/06/28 at 21:43:27, zmo wrote:
> LGTM
> 
> https://codereview.chromium.org/2109773003/diff/1/ui/gl/gl_version_info.cc
> File ui/gl/gl_version_info.cc (right):
> 
>
https://codereview.chromium.org/2109773003/diff/1/ui/gl/gl_version_info.cc#ne...
> ui/gl/gl_version_info.cc:96: bool has_sampler_indexing = IsAtLeastGL(4, 0) ||
IsAtLeastGLES(2, 0) ||
> nit: IsAtLeastGLES(2, 0) can be is_es, which is clearer.

Done

[Corentin Wallez, 2016-06-28 21:46:03]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2016-06-28 21:46:04]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2109773003/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2016-06-28 21:46:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-06-28 21:47:58]

lgtm too.

[commit-bot: I haz the power, 2016-06-28 23:36:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 23:36:29]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Corentin Wallez, 2016-06-29 03:55:08]

On 2016/06/28 at 23:36:29, commit-bot wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Failure seems unrelated, trying again.

[Corentin Wallez, 2016-06-29 03:55:10]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-06-29 03:55:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 04:39:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 04:41:42]

Description was changed from

==========
GLVersionInfo: for ES3 check for sampler array indexing

Index-constant sampler array indexing is a required feature for OpenGL
ES2 however some drivers silently support it and we can't gate OpenGL
ES2 support on GL_ARB_gpu_shader5 being present. That's why we only
enforce this feature for ES3.

BUG=598902
==========

to

==========
GLVersionInfo: for ES3 check for sampler array indexing

Index-constant sampler array indexing is a required feature for OpenGL
ES2 however some drivers silently support it and we can't gate OpenGL
ES2 support on GL_ARB_gpu_shader5 being present. That's why we only
enforce this feature for ES3.

BUG=598902

Committed: https://crrev.com/cf7b555abc38ee52485c0bbd0ae09a672f3348ce
Cr-Commit-Position: refs/heads/master@{#402719}
==========

[commit-bot: I haz the power, 2016-06-29 04:41:43]

Patchset 2 (id:??) landed as
https://crrev.com/cf7b555abc38ee52485c0bbd0ae09a672f3348ce
Cr-Commit-Position: refs/heads/master@{#402719}