Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2109763003:
Corrupted powerwash proposal UI (Closed)
|
Created:
4 years, 5 months ago by Qiang(Joe) Xu Modified:
4 years, 5 months ago Reviewers:
Alexander Alekseev CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCorrupted powerwash proposal UI
When getting screensize for powerwash reset, making sure the currentScreen is 'reset', not 'account-picker'.
BUG=615088
TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/956d75c97da94022381b07c336a4c258b04fb8bc
Cr-Commit-Position: refs/heads/master@{#402676}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
Description was changed from ========== Corrupted powerwash proposal UI BUG=615088 TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more. ========== to ========== Corrupted powerwash proposal UI BUG=615088 TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Corrupted powerwash proposal UI BUG=615088 TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Corrupted powerwash proposal UI BUG=615088 TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
warx@chromium.org changed reviewers: + alemate@chromium.org
Description was changed from ========== Corrupted powerwash proposal UI BUG=615088 TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Corrupted powerwash proposal UI When getting screensize for powerwash reset, making sure the currentScreen is 'reset', not 'account-picker'. BUG=615088 TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by warx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hi Alex, could you please take a look? tks
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by warx@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Corrupted powerwash proposal UI When getting screensize for powerwash reset, making sure the currentScreen is 'reset', not 'account-picker'. BUG=615088 TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Corrupted powerwash proposal UI When getting screensize for powerwash reset, making sure the currentScreen is 'reset', not 'account-picker'. BUG=615088 TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Corrupted powerwash proposal UI When getting screensize for powerwash reset, making sure the currentScreen is 'reset', not 'account-picker'. BUG=615088 TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Corrupted powerwash proposal UI When getting screensize for powerwash reset, making sure the currentScreen is 'reset', not 'account-picker'. BUG=615088 TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/956d75c97da94022381b07c336a4c258b04fb8bc Cr-Commit-Position: refs/heads/master@{#402676} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/956d75c97da94022381b07c336a4c258b04fb8bc Cr-Commit-Position: refs/heads/master@{#402676} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
