third_party: Update to version 7 of remote_shell_protocol

third_party: Update to version 7 of remote_shell_protocol

Adds state type changed event to remote_shell_protocol.

BUG=b/29817350

Committed: https://crrev.com/e33db1ac4c4186177431446e7c2313903a205195
Cr-Commit-Position: refs/heads/master@{#402630}

[reveman, 2016-06-28 18:29:33]

reveman@chromium.org changed reviewers:
+ oshima@chromium.org, yorkelee@chromium.org

[oshima, 2016-06-28 18:36:00]

lgtm

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:65:
<entry name="pinned" value="5" summary="pinned window state"/>
just q: is it possible to add new types in the future without causing
compatibility issue?

[hidehiko, 2016-06-28 18:44:23]

hidehiko@chromium.org changed reviewers:
+ hidehiko@chromium.org

[hidehiko, 2016-06-28 18:44:24]

drive-by.

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:125:
notification_surface role and associated it with a notification id.
nit: s/\t/        /

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:436:
<arg name="state_type" type="uint"/>
QQ: Don't we need previous state type?
Is it necessary to track the state in client, too?

[reveman, 2016-06-28 19:02:19]

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:65:
<entry name="pinned" value="5" summary="pinned window state"/>
On 2016/06/28 at 18:36:00, oshima wrote:
> just q: is it possible to add new types in the future without causing
compatibility issue?

yes, new types can be added as long as we're not changing the old of course.

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:125:
notification_surface role and associated it with a notification id.
On 2016/06/28 at 18:44:24, hidehiko wrote:
> nit: s/\t/        /

the rest of the file and other interfaces use tabs so I prefer to be consistent
with that

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:436:
<arg name="state_type" type="uint"/>
On 2016/06/28 at 18:44:24, hidehiko wrote:
> QQ: Don't we need previous state type?
> Is it necessary to track the state in client, too?

I considered this but I can't think of anything we'd need it for. I'm happy to
add it if you think it's a good idea.

[hidehiko, 2016-06-28 19:20:13]

lgtm.

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:125:
notification_surface role and associated it with a notification id.
On 2016/06/28 19:02:19, reveman wrote:
> On 2016/06/28 at 18:44:24, hidehiko wrote:
> > nit: s/\t/        /
> 
> the rest of the file and other interfaces use tabs so I prefer to be
consistent
> with that

Looks mixed? At least, your new "state_type_changed" uses 8 space indent?

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:436:
<arg name="state_type" type="uint"/>
On 2016/06/28 19:02:19, reveman wrote:
> On 2016/06/28 at 18:44:24, hidehiko wrote:
> > QQ: Don't we need previous state type?
> > Is it necessary to track the state in client, too?
> 
> I considered this but I can't think of anything we'd need it for. I'm happy to
> add it if you think it's a good idea.

Thank you for explanation. I just wanted to clarify if it is intentional. I do
not have any concrete case neither, so I'm fine with the current design.

[reveman, 2016-06-28 22:58:28]

The CQ bit was checked by reveman@chromium.org

[reveman, 2016-06-28 22:58:28]

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2109763002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:125:
notification_surface role and associated it with a notification id.
On 2016/06/28 at 19:20:12, hidehiko wrote:
> On 2016/06/28 19:02:19, reveman wrote:
> > On 2016/06/28 at 18:44:24, hidehiko wrote:
> > > nit: s/\t/        /
> > 
> > the rest of the file and other interfaces use tabs so I prefer to be
consistent
> > with that
> 
> Looks mixed? At least, your new "state_type_changed" uses 8 space indent?

The style of upstream interfaces is 2 space indent with 8 spaces being replaced
by a tab afaict. This file is consistent with that now.

[commit-bot: I haz the power, 2016-06-28 22:59:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 01:43:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 01:45:35]

Description was changed from

==========
third_party: Update to version 7 of remote_shell_protocol

Adds state type changed event to remote_shell_protocol.

BUG=b/29817350
==========

to

==========
third_party: Update to version 7 of remote_shell_protocol

Adds state type changed event to remote_shell_protocol.

BUG=b/29817350

Committed: https://crrev.com/e33db1ac4c4186177431446e7c2313903a205195
Cr-Commit-Position: refs/heads/master@{#402630}
==========

[commit-bot: I haz the power, 2016-06-29 01:45:36]

Patchset 1 (id:??) landed as
https://crrev.com/e33db1ac4c4186177431446e7c2313903a205195
Cr-Commit-Position: refs/heads/master@{#402630}