Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2109753002: [Chromecast] Set use_alsa=true only for Chromecast desktop & audio. (Closed)

Created:
4 years, 5 months ago by mbjorge
Modified:
4 years, 5 months ago
Reviewers:
slan, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, gfhuang, wzhong
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Set use_alsa=true only for Chromecast desktop & audio. For Cast builds, only cast desktop and cast audio-only products should use_alsa=true by default. BUG= internal b/29770818 TEST= Build several Cast platforms Committed: https://crrev.com/b7d6c2f36713c454974c180b81e6571608ccc696 Cr-Commit-Position: refs/heads/master@{#402674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M media/media_options.gni View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
mbjorge
4 years, 5 months ago (2016-06-28 19:08:53 UTC) #2
DaleCurtis
lgtm
4 years, 5 months ago (2016-06-28 19:11:31 UTC) #4
slan
lgtm
4 years, 5 months ago (2016-06-28 19:12:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109753002/1
4 years, 5 months ago (2016-06-28 19:16:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/235916)
4 years, 5 months ago (2016-06-28 20:04:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109753002/1
4 years, 5 months ago (2016-06-28 20:38:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/254152)
4 years, 5 months ago (2016-06-28 22:27:12 UTC) #13
mbjorge
Looks like a second unrelated failure. Trying commit again
4 years, 5 months ago (2016-06-28 23:37:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109753002/1
4 years, 5 months ago (2016-06-28 23:38:57 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 02:27:45 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 02:30:39 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7d6c2f36713c454974c180b81e6571608ccc696
Cr-Commit-Position: refs/heads/master@{#402674}

Powered by Google App Engine
This is Rietveld 408576698