Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/constants_dbc.h

Issue 2109743002: DBC: Implement InstanceOf. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fold in negate_result; check the cache in the interpreter Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_dbc.cc » ('j') | runtime/vm/intermediate_language_dbc.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/constants_dbc.h
diff --git a/runtime/vm/constants_dbc.h b/runtime/vm/constants_dbc.h
index 4f8aab93ec22373f9d82a148e12da85e519ef39f..8f413bfddb935fae828fc687c16ca051b0d371e1 100644
--- a/runtime/vm/constants_dbc.h
+++ b/runtime/vm/constants_dbc.h
@@ -340,6 +340,11 @@ namespace dart {
//
// Instantiate type arguments PP[D] with instantiator SP[0].
//
+// - InstanceOf A
+//
+// Test if instance SP[-3] with type arguments SP[-2] is (A = 0) or is not
+// (A = 1) a subtype of SP[-1] using SubtypeTestCache SP[0].
zra 2016/06/28 21:37:47 With result at top of stack.
rmacnak 2016/06/28 22:22:55 Done.
+//
// - AssertAssignable D
//
// Assert that SP[-3] is assignable to variable named SP[0] of type
@@ -499,6 +504,7 @@ namespace dart {
V(MoveSpecial, A_D, reg, num, ___) \
V(InstantiateType, D, lit, ___, ___) \
V(InstantiateTypeArgumentsTOS, A_D, num, lit, ___) \
+ V(InstanceOf, A, num, ___, ___) \
V(AssertAssignable, D, num, lit, ___) \
V(AssertBoolean, A, num, ___, ___) \
V(CheckSmi, A, reg, ___, ___) \
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_dbc.cc » ('j') | runtime/vm/intermediate_language_dbc.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698