DBC: Implement InstanceOf.

runtime/vm/simulator_dbc.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <setjmp.h>  // NOLINT
 #include <stdlib.h>
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_DBC)
 
@@ skipping 1836 matching lines @@
     SP[1] = SP[-0];  // Length.
     SP[2] = SP[-1];  // Type.
     Exit(thread, FP, SP + 3, pc);
     NativeArguments args(thread, 2, SP + 1, SP - 1);
     INVOKE_RUNTIME(DRT_AllocateArray, args);
     SP -= 1;
     DISPATCH();
   }
 
   {
+    BYTECODE(InstanceOf, 0);  // Stack: instance, type args, type, cache
+    RawInstance* instance = static_cast<RawInstance*>(SP[-3]);

[zra, 2016/06/28 19:30:35]

If you use the RAW_CAST macro, we'll also get some good ASSERTs for these in
Debug builds.

[rmacnak, 2016/06/28 21:21:50]

RAW_CAST is too strict here. type_args may be null, type may be Type or
TypeParameter or FunctionType, etc.

+    RawTypeArguments* type_args = static_cast<RawTypeArguments*>(SP[-2]);
+    RawAbstractType* raw_type = static_cast<RawAbstractType*>(SP[-1]);
+    RawSubtypeTestCache* cache = static_cast<RawSubtypeTestCache*>(SP[0]);
+
+    const AbstractType& type = AbstractType::Handle(raw_type);
+    if (type.IsInstantiated()) {
+      if (instance == null_value) {
+        SP[-3] = type.IsNullType() ? true_value : false_value;
+        goto InstanceOfOk;
+      }
+    }
+
+    // TODO(rmacnak): Use the cache.
+
+    {
+      SP[1] = instance;
+      SP[2] = raw_type;
+      SP[3] = type_args;
+      SP[4] = cache;
+      Exit(thread, FP, SP + 5, pc);
+      NativeArguments native_args(thread, 4, SP + 1, SP - 3);
+      INVOKE_RUNTIME(DRT_Instanceof, native_args);
+    }
+
+  InstanceOfOk:
+    SP -= 3;
+    DISPATCH();
+  }
+
+  {
     BYTECODE(AssertAssignable, A_D);  // Stack: instance, type args, type, name
     RawObject** args = SP - 3;
     if (args[0] != null_value) {
       const AbstractType& dst_type =
           AbstractType::Handle(static_cast<RawAbstractType*>(args[2]));
       if (dst_type.IsMalformedOrMalbounded()) {
         SP[1] = args[0];  // instance.
         SP[2] = args[3];  // name.
         SP[3] = args[2];  // type.
         Exit(thread, FP, SP + 4, pc);
@@ skipping 104 matching lines @@
     const RawSmi* actual_cid =
         SimulatorHelpers::GetClassIdAsSmi(static_cast<RawObject*>(FP[rA]));
     const RawSmi* desired_cid = RAW_CAST(Smi, LOAD_CONSTANT(rD));
     if (actual_cid == desired_cid) {
       pc++;
     }
     DISPATCH();
   }
 
   {
+    BYTECODE(LogicalNot, 0);
+    SP[0] = (SP[0] == true_value) ? false_value : true_value;
+    DISPATCH();
+  }
+
+  {
     BYTECODE(IfEqStrictTOS, 0);
     SP -= 2;
     if (SP[1] != SP[2]) {
       pc++;
     }
     DISPATCH();
   }
 
   {
     BYTECODE(IfNeStrictTOS, 0);
@@ skipping 299 matching lines @@
   special_[kExceptionSpecialIndex] = raw_exception;
   special_[kStacktraceSpecialIndex] = raw_stacktrace;
   buf->Longjmp();
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 
 #endif  // defined TARGET_ARCH_DBC