Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 210973004: Support invalidation sets for :-webkit-any selectors. (Closed)

Created:
6 years, 9 months ago by rune
Modified:
6 years, 9 months ago
Reviewers:
esprehn
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Support invalidation sets for :-webkit-any selectors. Traverse the selectorList() like we do for :host to find features for invalidation sets. Relevance for 351613 is that we need to support this in order to implement efficient invalidation sets for :hover with childrenAffectedByHover due to UA stylesheet rules. R=esprehn BUG=356125, 351613 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -3 lines) Patch
A LayoutTests/fast/css/invalidation/targeted-class-any-pseudo.html View 1 chunk +84 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/targeted-class-any-pseudo-expected.txt View 1 chunk +29 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
rune
6 years, 9 months ago (2014-03-25 13:11:16 UTC) #1
esprehn
lgtm
6 years, 9 months ago (2014-03-27 13:06:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/210973004/1
6 years, 9 months ago (2014-03-27 13:07:03 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 13:10:08 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 13:10:08 UTC) #5
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-27 13:11:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/210973004/1
6 years, 9 months ago (2014-03-27 13:11:54 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:24:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 14:24:12 UTC) #9
rune
The CQ bit was checked by rune@opera.com
6 years, 9 months ago (2014-03-27 20:29:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/210973004/1
6 years, 9 months ago (2014-03-27 20:30:09 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:32:36 UTC) #12
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 22:32:37 UTC) #13
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-27 22:36:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/210973004/1
6 years, 9 months ago (2014-03-27 22:38:28 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 22:40:23 UTC) #16
Message was sent while issue was closed.
Change committed as 170212

Powered by Google App Engine
This is Rietveld 408576698