Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2109703002: Revert of exo: Take blending into account when setting opaque property. (Closed)

Created:
4 years, 5 months ago by Pete Williamson
Modified:
4 years, 5 months ago
Reviewers:
reveman, jbauman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of exo: Take blending into account when setting opaque property. (patchset #1 id:1 of https://codereview.chromium.org/2101453002/ ) Reason for revert: This seems to be causing ChromiumOS waterfall trybots to fail, Reverting as Sheriff. Failure logs here: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN Original issue's description: > exo: Take blending into account when setting opaque property. > > This makes SetFillsBoundsOpaquely() call consistent with opaque_rect > used in UpdateSurface() when creating a texture quad. > > BUG=549781 > > Committed: https://crrev.com/d418b059202ca86880ed287b9a33f6d947123691 > Cr-Commit-Position: refs/heads/master@{#402430} TBR=jbauman@chromium.org,reveman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549781 Committed: https://crrev.com/0dfdf21abd72fcbf75c18cdbb633148f5eb10529 Cr-Commit-Position: refs/heads/master@{#402493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/exo/surface.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Pete Williamson
Created Revert of exo: Take blending into account when setting opaque property.
4 years, 5 months ago (2016-06-28 17:02:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109703002/1
4 years, 5 months ago (2016-06-28 17:02:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 17:03:54 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 17:07:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dfdf21abd72fcbf75c18cdbb633148f5eb10529
Cr-Commit-Position: refs/heads/master@{#402493}

Powered by Google App Engine
This is Rietveld 408576698