Fix up some tests for copy-or-move validator and nearby.

webkit/browser/fileapi/test_file_system_backend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/browser/fileapi/test_file_system_backend.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 167 matching lines @@
   if (require_copy_or_move_validator_) {
     if (!copy_or_move_file_validator_factory_)
       *error_code = base::PLATFORM_FILE_ERROR_SECURITY;
     return copy_or_move_file_validator_factory_.get();
   }
   return NULL;
 }
 
 void TestFileSystemBackend::InitializeCopyOrMoveFileValidatorFactory(
     scoped_ptr<CopyOrMoveFileValidatorFactory> factory) {
-  // What purpose is this check serving?
-  if (!require_copy_or_move_validator_) {

[vandebo (ex-Chrome), 2013/07/31 18:45:06]

Since this is unused, completely remove it from the file.

[Greg Billock, 2013/07/31 19:01:54]

It's used further down.

[vandebo (ex-Chrome), 2013/07/31 20:27:57]

Not really - initialized to false and never changed.

[Greg Billock, 2013/07/31 21:57:58]

As discussed, there's a missing test here -- making sure the copy operation
fails security if it finds a bad return from the factory getter.

The other test we worried about (return OK + validator=null --> no validation
needed and copy should complete) is already getting covered.

-    DCHECK(!factory);
-    return;
-  }
   if (!copy_or_move_file_validator_factory_)
     copy_or_move_file_validator_factory_ = factory.Pass();
 }
 
 FileSystemOperation* TestFileSystemBackend::CreateFileSystemOperation(
     const FileSystemURL& url,
     FileSystemContext* context,
     base::PlatformFileError* error_code) const {
   scoped_ptr<FileSystemOperationContext> operation_context(
       new FileSystemOperationContext(context));
@@ skipping 34 matching lines @@
   return quota_util_->GetUpdateObservers(type);
 }
 
 void TestFileSystemBackend::AddFileChangeObserver(
     FileChangeObserver* observer) {
   quota_util_->AddFileChangeObserver(
       kFileSystemTypeTest, observer, quota_util_->task_runner());
 }
 
 }  // namespace fileapi