Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2109673002: Add 'x' button to the signin promo in the password bubble. (Closed)

Created:
4 years, 5 months ago by vasilii
Modified:
4 years, 5 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 'x' button to the signin promo in the password bubble. BUG=615825 Committed: https://crrev.com/d0b53a62d7be6089bb030227fd90fc28efc18b83 Cr-Commit-Position: refs/heads/master@{#402489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vasilii
Hi Vaclav, please review.
4 years, 5 months ago (2016-06-28 15:24:32 UTC) #2
vabr (Chromium)
lgtm
4 years, 5 months ago (2016-06-28 15:51:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109673002/1
4 years, 5 months ago (2016-06-28 16:04:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 16:38:54 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 16:40:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0b53a62d7be6089bb030227fd90fc28efc18b83
Cr-Commit-Position: refs/heads/master@{#402489}

Powered by Google App Engine
This is Rietveld 408576698