chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java - Issue 2109643003: Add billing address to masked server credit cards.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java

Issue 2109643003: Add billing address to masked server credit cards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Delete AutofillServerCardPreferences.java Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java » ('j') | components/autofill/core/browser/webdata/autofill_table.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java

index 8317e1530eed3a7c43ca1e9a3a26ec9fa47a6a26..810428bffdcbb33b2b02ea163718b6bb5ff9ba6f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java

@@ -92,7 +92,12 @@ public abstract class AutofillEditorBase

inflater.inflate(R.menu.payments_editor_menu, menu);

MenuItem deleteItem = menu.findItem(R.id.delete_menu_id);

- if (deleteItem != null) deleteItem.setVisible(!mIsNewEntry);

+ if (deleteItem != null) deleteItem.setVisible(!mIsNewEntry && getIsDeletable());

+ }

+ /** @return True if the item is deletable. Can be false for server credit cards, for example. */

+ protected boolean getIsDeletable() {

+ return true;

}

/** Initializes the buttons within the layout. */