Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2109643002: Fix DCHECKs caused by in-process gpu thread. (Closed)

Created:
4 years, 5 months ago by Alexander Semashko
Modified:
4 years, 5 months ago
Reviewers:
jbauman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECKs caused by in-process gpu thread. When run in-process, the GpuSwitchingManager is already notified in GpuDataManagerImplPrivate::HandleGpuSwitch. The call from GpuChildThread causes GpuSwitchingManager to notify its obervers on the GPU thread, while they're expecting it to be UI thread. As a result, a dozen or two of content_browsertests are failing for me in each run (mac debug build). BUG= Committed: https://crrev.com/9afba1026d1bc33b69fbc2d25c019db6aa24f6ca Cr-Commit-Position: refs/heads/master@{#402568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/gpu/gpu_child_thread.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Alexander Semashko
4 years, 5 months ago (2016-06-28 13:53:09 UTC) #2
jbauman
lgtm
4 years, 5 months ago (2016-06-28 20:30:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109643002/1
4 years, 5 months ago (2016-06-28 20:33:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 22:15:23 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 22:17:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9afba1026d1bc33b69fbc2d25c019db6aa24f6ca
Cr-Commit-Position: refs/heads/master@{#402568}

Powered by Google App Engine
This is Rietveld 408576698