content/test/data/navigation_handle_https_upgrade_test.html - Issue 2109633002: Executed HTTPS upgrade before notifying the start of the provisional load.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/data/navigation_handle_https_upgrade_test.html

Issue 2109633002: Executed HTTPS upgrade before notifying the start of the provisional load. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed mkwst@'s comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_handle_impl_browsertest.cc ('K') | « content/browser/frame_host/navigation_handle_impl_browsertest.cc ('k') | testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter » ('j') | third_party/WebKit/Source/core/loader/FrameFetchContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/data/navigation_handle_https_upgrade_test.html

diff --git a/content/test/data/mixed-content/basic-passive-in-iframe-with-upgrade.html b/content/test/data/navigation_handle_https_upgrade_test.html

similarity index 52%

copy from content/test/data/mixed-content/basic-passive-in-iframe-with-upgrade.html

copy to content/test/data/navigation_handle_https_upgrade_test.html

index aba4a04539d283b365d568e2b95cdb1350a6d283..4246117048bf82ddb43ad441b98077abf786cb87 100644

--- a/content/test/data/mixed-content/basic-passive-in-iframe-with-upgrade.html

+++ b/content/test/data/navigation_handle_https_upgrade_test.html

@@ -1,9 +1,10 @@

<!DOCTYPE html>

<html>

-<head>

-</head>

+<title>NavigationHandleImpl HTTPS upgrade test</title>

clamy 2016/07/04 11:22:09 How about just naming the file HTTPS upgrade (same

carlosk 2016/07/05 09:57:24 Done.

<body>

- <iframe src="/cross-site/a.com/mixed-content/basic-passive.html"></iframe>

+ <iframe src="http://other.com/title1.html"></iframe>

</body>

</html>