Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Issue 2109633002: Executed HTTPS upgrade before notifying the start of the provisional load. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nasko@'s comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
index 31e8389897ba03dbbff62479cf5bd80ba306983d..125574198187efcb950f2f282e08add791c2c5f6 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
@@ -410,7 +410,8 @@ Resource* ResourceFetcher::requestResource(FetchRequest& request, const Resource
{
ASSERT(request.options().synchronousPolicy == RequestAsynchronously || factory.type() == Resource::Raw || factory.type() == Resource::XSLStyleSheet);
- context().upgradeInsecureRequest(request);
+ if (request.resourceRequest().httpHeaderField("Upgrade-Insecure-Requests") != AtomicString("1"))
Mike West 2016/07/04 08:33:25 1. Can you add a comment describing the rationale
carlosk 2016/07/04 09:22:59 Both done. Much better indeed.
+ context().upgradeInsecureRequest(request.mutableResourceRequest());
context().addClientHintsIfNecessary(request);
context().addCSPHeaderIfNecessary(factory.type(), request);

Powered by Google App Engine
This is Rietveld 408576698