Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2109623002: [turbofan] Introduce proper CheckNumber operator. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce proper CheckNumber operator. We use CheckNumber to guard values as being proper numbers, i.e. if the input value is anything but a Number, we deoptimize. This follows the existing effect/control linearization magic that we already use for the other checks. R=jarin@chromium.org BUG=v8:5141 Committed: https://crrev.com/d5ed22808f6960bb4307fd8ea738603a66594099 Cr-Commit-Position: refs/heads/master@{#37329}

Patch Set 1 #

Patch Set 2 : Add to RedundancyElimination #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -13 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 2 chunks +4 lines, -13 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/redundancy-elimination.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Benedikt Meurer
4 years, 5 months ago (2016-06-28 12:16:12 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the CheckNumber magic for JSNativeContextSpecialization. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-06-28 12:17:00 UTC) #2
Jarin
lgtm
4 years, 5 months ago (2016-06-28 12:31:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109623002/1
4 years, 5 months ago (2016-06-28 12:35:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109623002/20001
4 years, 5 months ago (2016-06-28 12:37:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 13:08:36 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 13:09:16 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5ed22808f6960bb4307fd8ea738603a66594099
Cr-Commit-Position: refs/heads/master@{#37329}

Powered by Google App Engine
This is Rietveld 408576698