Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2109613007: Robustify Internals entry points against detached uses. (Closed)

Created:
4 years, 5 months ago by sof
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Robustify Internals entry points against detached uses. Fuzzers generate pointless overhead using these test-only methods from frame-detached contexts. Add required nullchecks throughout. Simple test case for each of these entry points (w/ --run-layout-test): <a href="javascript:'replaced'" id=anchor>click</a> <script> anchor.click(); internals.someMethod(); console.log('no crash'); </script> R= BUG=624549 Committed: https://crrev.com/7cbd7fb7916064d9a72b099c7ea6d1d5c9e769a1 Cr-Commit-Position: refs/heads/master@{#403421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M third_party/WebKit/Source/core/testing/Internals.cpp View 12 chunks +57 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look.
4 years, 5 months ago (2016-06-30 21:09:44 UTC) #2
haraken
LGTM
4 years, 5 months ago (2016-07-01 00:31:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109613007/1
4 years, 5 months ago (2016-07-01 05:40:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 07:24:09 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 07:24:13 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 07:26:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cbd7fb7916064d9a72b099c7ea6d1d5c9e769a1
Cr-Commit-Position: refs/heads/master@{#403421}

Powered by Google App Engine
This is Rietveld 408576698