Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2109613005: mash: Move system tray cast code into //ash/common (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
CC:
chromium-reviews, kalyank, sadrul, extensions-reviews_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move system tray cast code into //ash/common This is a dependency of SystemTray. * Move //ash/system/chromeos/screen_security to //ash/common * Move cast_config_delegate.* to //ash/common * Move //ash/system/cast to //ash/common * Fix include guards * Fix some IWYU BUG=619636 TEST=ash_unittests TBR=rockot@chromium.org Committed: https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4 Cr-Commit-Position: refs/heads/master@{#402944}

Patch Set 1 #

Patch Set 2 : forward decl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1783 lines) Patch
M ash/ash.gyp View 8 chunks +11 lines, -11 lines 0 comments Download
D ash/cast_config_delegate.h View 1 chunk +0 lines, -124 lines 0 comments Download
D ash/cast_config_delegate.cc View 1 chunk +0 lines, -21 lines 0 comments Download
A + ash/common/cast_config_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/cast_config_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/cast/tray_cast.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/system/cast/tray_cast.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/common/system/chromeos/screen_security/screen_capture_tray_item.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/system/chromeos/screen_security/screen_capture_tray_item.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/chromeos/screen_security/screen_share_tray_item.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/system/chromeos/screen_security/screen_share_tray_item.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/chromeos/screen_security/screen_tray_item.h View 2 chunks +5 lines, -3 lines 0 comments Download
A + ash/common/system/chromeos/screen_security/screen_tray_item.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/chromeos/screen_security/screen_tray_item_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
D ash/system/cast/tray_cast.h View 1 chunk +0 lines, -80 lines 0 comments Download
D ash/system/cast/tray_cast.cc View 1 chunk +0 lines, -670 lines 0 comments Download
M ash/system/chromeos/multi_user/user_switch_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/multi_user/user_switch_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/chromeos/screen_security/screen_capture_tray_item.h View 1 chunk +0 lines, -52 lines 0 comments Download
D ash/system/chromeos/screen_security/screen_capture_tray_item.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D ash/system/chromeos/screen_security/screen_share_tray_item.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ash/system/chromeos/screen_security/screen_share_tray_item.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D ash/system/chromeos/screen_security/screen_tray_item.h View 1 chunk +0 lines, -136 lines 0 comments Download
D ash/system/chromeos/screen_security/screen_tray_item.cc View 1 chunk +0 lines, -190 lines 0 comments Download
D ash/system/chromeos/screen_security/screen_tray_item_unittest.cc View 1 chunk +0 lines, -219 lines 0 comments Download
M ash/system/tray/system_tray.h View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M ash/test/tray_cast_test_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/tray_cast_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cast_devices_private/cast_devices_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/cast_config_delegate_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/cast_config_delegate_media_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
James Cook
msw, please take a look. This is a mechanical move with the usual cleanup tweaks.
4 years, 5 months ago (2016-06-29 20:31:43 UTC) #3
msw
lgtm
4 years, 5 months ago (2016-06-29 21:09:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109613005/20001
4 years, 5 months ago (2016-06-29 21:17:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/209827)
4 years, 5 months ago (2016-06-29 21:34:24 UTC) #8
James Cook
TBR rockot for trivial rename touching c/b/extensions (and the cast API has no OWNERS file)
4 years, 5 months ago (2016-06-29 21:36:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109613005/20001
4 years, 5 months ago (2016-06-29 21:38:17 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 22:11:46 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:15:26 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4
Cr-Commit-Position: refs/heads/master@{#402944}

Powered by Google App Engine
This is Rietveld 408576698