Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 2109603002: Use proper write barrier mode when creating rest parameters. (Closed)

Created:
4 years, 5 months ago by Igor Sheludko
Modified:
4 years, 5 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use proper write barrier mode when creating rest parameters. BUG=chromium:623912 Committed: https://crrev.com/e6076a79516339fd4b6780ec45804097c70c8ea0 Cr-Commit-Position: refs/heads/master@{#37326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/runtime/runtime-scopes.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109603002/1
4 years, 5 months ago (2016-06-28 11:42:21 UTC) #3
Igor Sheludko
PTAL
4 years, 5 months ago (2016-06-28 11:43:07 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 12:06:20 UTC) #7
Michael Lippautz
lgtm
4 years, 5 months ago (2016-06-28 12:37:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109603002/1
4 years, 5 months ago (2016-06-28 12:38:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 12:40:24 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 12:42:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6076a79516339fd4b6780ec45804097c70c8ea0
Cr-Commit-Position: refs/heads/master@{#37326}

Powered by Google App Engine
This is Rietveld 408576698