Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: gyp/opts.gyp

Issue 21096005: update gyp for ARM builds to be more well defined. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gyp/opts.gyp
diff --git a/gyp/opts.gyp b/gyp/opts.gyp
index 8aa5e0f6bd1c7b1d5048a5278fd295b5b988e01b..fb116c4e599ef0490804c71b46c8d33989a06c92 100644
--- a/gyp/opts.gyp
+++ b/gyp/opts.gyp
@@ -56,7 +56,7 @@
'../src/opts/SkUtils_opts_SSE2.cpp',
],
}],
- [ 'skia_arch_type == "arm" and armv7 == 1', {
+ [ 'skia_arch_type == "arm"', {
# The assembly uses the frame pointer register (r7 in Thumb/r11 in
# ARM), the compiler doesn't like that.
'cflags!': [
@@ -94,7 +94,7 @@
}],
],
}],
- [ '(skia_arch_type == "arm" and armv7 == 0) or (skia_os == "ios")', {
+ [ '(skia_arch_type != "arm") or (skia_os == "ios")', {
mtklein 2013/07/29 20:02:16 Wouldn't the equivalent be, skia_arch_type == "arm
'sources': [
'../src/opts/SkBitmapProcState_opts_none.cpp',
'../src/opts/SkBlitRow_opts_none.cpp',

Powered by Google App Engine
This is Rietveld 408576698